Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update setup-gams #12

Merged
merged 15 commits into from
Feb 6, 2024
Merged

Update setup-gams #12

merged 15 commits into from
Feb 6, 2024

Conversation

glatterf42
Copy link
Member

This PR merges the branch that was used to debug the recent CI failures for setup-gams on message_ix. It mainly removes the GHA_PATH environment variable in favor of the existing GITHUB_ACTION_PATH. It also removes the --silent option from curl, which doesn't seem necessary.

Merging this will allow iiasa/message_ix#790 to receive a commit that makes it use the main version of this action again. The commits can definitely be squashed.

@glatterf42 glatterf42 added the enhancement New feature or request label Feb 6, 2024
@glatterf42 glatterf42 self-assigned this Feb 6, 2024
@khaeru
Copy link
Member

khaeru commented Feb 6, 2024

Great, happy to discard this.

At https://github.com/iiasa/message_ix/actions/runs/7795538531/job/21259299435#step:10:10061 there appear to be about 10000 lines of log output from cURL. Will these always be present in the log / is this because of removing --silent? Or due to something else that is temporary, thus they will disappear?

@glatterf42
Copy link
Member Author

This is because I accidentally left the -v on curl for increased verbosity. In the latest runs, these lines are not there anymore :)

Copy link
Member

@khaeru khaeru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that was the same URL. But I re-ran the job again (here) and indeed the lines are gone, so LGTM.

@glatterf42 glatterf42 merged commit 5b5c0c2 into main Feb 6, 2024
6 checks passed
@glatterf42 glatterf42 deleted the debug-setup-gams branch February 6, 2024 09:45
@khaeru khaeru mentioned this pull request Feb 6, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants