Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI #790

Merged
merged 6 commits into from
Feb 6, 2024
Merged

Update CI #790

merged 6 commits into from
Feb 6, 2024

Conversation

glatterf42
Copy link
Member

@glatterf42 glatterf42 commented Feb 5, 2024

Closes #788. This PR updates the CI to address several minor issues:

  • Bump cache-action version
  • Bump Codecov-action version using newly added repo secret
  • Remove temporary genno pin

We can also use this to solve the current CI failure of the windows-tutorials test. As far as I can see, this failure stems from a cache being used -- at least, the setup-gams step does not fail for the other windows-CI-tests not using a cache for gams. (was resolved by iiasa/actions#12)

How to review

  • Read the diff and note that the CI checks all pass.

PR checklist

  • Continuous integration checks all ✅
  • Add or expand tests; coverage checks both ✅
  • [ ] Add, expand, or update documentation. Just CI updates
  • [ ] Update release notes. Just CI updates

* Bump cache-action version
* Bump Codecov-action version using newly added repo secret
* Remove temporary genno pin
@glatterf42 glatterf42 added the ci Continuous integration label Feb 5, 2024
@glatterf42 glatterf42 added this to the 3.9 milestone Feb 5, 2024
@glatterf42 glatterf42 self-assigned this Feb 5, 2024
Copy link

codecov bot commented Feb 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4dae41e) 95.2% compared to head (b26151a) 95.2%.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #790   +/-   ##
=====================================
  Coverage   95.2%   95.2%           
=====================================
  Files         46      46           
  Lines       4335    4335           
=====================================
  Hits        4130    4130           
  Misses       205     205           

@glatterf42
Copy link
Member Author

@khaeru This PR is ready in principle, the only thing we might want to still adapt is the pre-commit action usage.

Copy link
Member

@khaeru khaeru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to go. There is some added whitespace on empty lines in pytest.yaml, I guess unintentional.

I'd vote that we make a general decision on how to invoke pre-commit and then implement it later.

@glatterf42
Copy link
Member Author

Good catch, thanks :)

@glatterf42 glatterf42 merged commit a488b8a into iiasa:main Feb 6, 2024
24 checks passed
@glatterf42 glatterf42 deleted the update/ci-versions branch February 6, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Track/adjust for test failure with genno 1.23.0
2 participants