Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address hardcoded units MACRO calibration and M-M linkage #317

Open
khaeru opened this issue Mar 15, 2020 · 6 comments
Open

Address hardcoded units MACRO calibration and M-M linkage #317

khaeru opened this issue Mar 15, 2020 · 6 comments
Labels
macro MACRO model or MESSAGE-MACRO link

Comments

@khaeru
Copy link
Member

khaeru commented Mar 15, 2020

To complete the code added #223, address the point raised there by @gidden:

There are a variety of places in the previous R code as well as existing GAMS code where unit conversions are hardcoded (usually going from $B to $T via either / 1000 or / 1e3).

(To clarify: message_ix.macro code was transcribed from an R script. The unit conversions were carried into the Python code. This is undesirable since the code should operate with whichever units the user inputs.)

This can be resolved in one or more of the following ways:

  1. At a minimum, clearly describe (e.g. in message_ix.macro lacks minimal documentation #315) the meaning/difference between units of quantities in MACRO and MESSAGE, so that users can understand how to interpret their values.
  2. Per TODOs inline in message_ix.macro: read, parse, and follow the existing units in the Scenario being modified.
  3. Remove hard-coded conversions in the MESSAGE or MACRO GAMS code.
@khaeru khaeru added this to the 3.0 milestone Mar 15, 2020
@khaeru khaeru added the macro MACRO model or MESSAGE-MACRO link label Apr 20, 2020
khaeru added a commit that referenced this issue May 29, 2020
@khaeru
Copy link
Member Author

khaeru commented Jun 7, 2020

Postponing to after v3.0.

@khaeru khaeru modified the milestones: 3.0, 3.1 Jun 7, 2020
@khaeru khaeru modified the milestones: 3.1, 3.2 Aug 25, 2020
@khaeru
Copy link
Member Author

khaeru commented Jan 14, 2021

No one was assigned to do this by the feature freeze for v3.2.0, so we postpone to v3.3 (or later).

@khaeru khaeru modified the milestones: 3.2, 3.3 Jan 14, 2021
@khaeru
Copy link
Member Author

khaeru commented May 24, 2021

No one was assigned to do this by the feature freeze for v3.3.0, so we postpone to v3.4 (or later).

@khaeru khaeru modified the milestones: 3.3, 3.4 May 24, 2021
@LauWien
Copy link
Contributor

LauWien commented Jan 13, 2022

No one was assigned to do this for v3.4.0, so we postpone to v3.5 (or later).

@LauWien LauWien modified the milestones: 3.4, 3.5 Jan 13, 2022
@LauWien
Copy link
Contributor

LauWien commented Apr 22, 2022

No one was assigned to do this by the feature freeze for v3.5.0, so we postpone to v3.6 (or later).

@LauWien LauWien modified the milestones: 3.5, 3.6 Apr 22, 2022
@khaeru
Copy link
Member Author

khaeru commented Aug 17, 2022

Removing the milestone entirely. It can be re-added if/when the team decides to schedule/assign the work.

@khaeru khaeru removed this from the 3.6 milestone Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
macro MACRO model or MESSAGE-MACRO link
Projects
None yet
Development

No branches or pull requests

2 participants