Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify add_macro() behaviour on a non-'clean' Scenario #320

Open
khaeru opened this issue Mar 15, 2020 · 6 comments
Open

Clarify add_macro() behaviour on a non-'clean' Scenario #320

khaeru opened this issue Mar 15, 2020 · 6 comments
Labels
macro MACRO model or MESSAGE-MACRO link

Comments

@khaeru
Copy link
Member

khaeru commented Mar 15, 2020

In #223, there was a discussion (#223 (comment)) of how Scenario.add_macro should behave when the target Scenario already contains MACRO-related items or data; i.e. should it:

  • refuse to proceed and raise an Exception,
  • overwrite the existing content, or
  • something else?

At minimum, a clear description of the behaviour is needed before this feature can be released with message_ix 3.0. Ideally, more thorough checks and informative messages would help users avoid errors.

@khaeru khaeru added this to the 3.0 milestone Mar 15, 2020
@khaeru khaeru added the macro MACRO model or MESSAGE-MACRO link label Apr 20, 2020
khaeru added a commit that referenced this issue May 29, 2020
@khaeru
Copy link
Member Author

khaeru commented Jun 7, 2020

Postponing to after v3.0.

@khaeru khaeru modified the milestones: 3.0, 3.1 Jun 7, 2020
@khaeru khaeru modified the milestones: 3.1, 3.2 Aug 25, 2020
@khaeru
Copy link
Member Author

khaeru commented Jan 14, 2021

No one was assigned to do this by the feature freeze for v3.2.0, so we postpone to v3.3 (or later).

@khaeru khaeru modified the milestones: 3.2, 3.3 Jan 14, 2021
@khaeru
Copy link
Member Author

khaeru commented May 24, 2021

No one was assigned to do this by the feature freeze for v3.3.0, so we postpone to v3.4 (or later).

@khaeru khaeru modified the milestones: 3.3, 3.4 May 24, 2021
@LauWien
Copy link
Contributor

LauWien commented Jan 13, 2022

No one was assigned to do this for v3.4.0, so we postpone to v3.5 (or later).

@LauWien LauWien modified the milestones: 3.4, 3.5 Jan 13, 2022
@LauWien
Copy link
Contributor

LauWien commented Apr 22, 2022

No one was assigned to do this by the feature freeze for v3.5.0, so we postpone to v3.6 (or later).

@LauWien LauWien modified the milestones: 3.5, 3.6 Apr 22, 2022
@khaeru
Copy link
Member Author

khaeru commented Aug 17, 2022

Removing the milestone entirely. It can be re-added if/when the team decides to schedule/assign the work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
macro MACRO model or MESSAGE-MACRO link
Projects
None yet
Development

No branches or pull requests

2 participants