-
Notifications
You must be signed in to change notification settings - Fork 552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add @@PLUGINSTART-USE-STRICT@@ Replacement #1187
base: master
Are you sure you want to change the base?
Conversation
@@PLUGINSTART-USE-STRICT@@ is replaced with the standard PLUGINSTART code and "use strict"; Also add a --verbose option to show which files are buing built.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uh, there's a lot more changes here than should be necessary for the patch. It should just need the pluginWrapperUseStrict (which, really, should be X + usecommon) and then the alternate macro.
Okay, I can back out the verbose option easy enough. And make the other requested change. A pluginWrapperUseStrict = pluginWrapperStart + "use strict;" approach will not work since the "use strict" needs to go immediately after the |
I'd have pluginWrapperStartCommon = "most of it"; and then pluginWrapperStart and pluginWrapperStartStrict add the extra couple lines at the top |
Insert "use strict"; using string replace on pluginWrapperStart. Remove --verbose option.
After considering the options, I went with the one line approach:
Also removed the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Erm, you just added a couple extra files.
Sorry, this is the first time I've done this with a repository that wasn't mine. I'll get to it. Thanks for keeping me on track. |
I got this down to the one file and checked it via the "Files Changed" link, above. |
The replacement is the standard PLUGINSTART code followed by "use strict";. by @hayeswise iitc-project/ingress-intel-total-conversion#1187 #2
Add support for new replacement, @@PLUGINSTART-USE-STRICT@@. The replacement is the standard PLUGINSTART code followed by
"use strict";
.For plugin example that uses this:
Following has been removed per guidance from nhamer to keep the changes focused on one item:
Also add a
--verbose
option to show which files are being built.Sample verbose option output during the build: