Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always use period for decimal point when converting double to string #3

Closed
elijahandrews opened this issue Jul 12, 2013 · 2 comments
Closed

Always use period for decimal point when converting double to string #3

elijahandrews opened this issue Jul 12, 2013 · 2 comments

Comments

@elijahandrews
Copy link

Right now, conversion from double to string executed by NonBlockingStatsDClient.FORMAT depends on the locale of the user. If the user's locale is one where a comma is used as a decimal point, the Datadog Agent will not be able to parse a metric with a double value.
@ghost ghost mentioned this issue Jul 22, 2013
Merged
charles-dyfis-net pushed a commit that referenced this issue Jul 22, 2013
@kaufda
Fix for issues #3 and #4 with regression test for #3
d445d74
charles-dyfis-net added a commit that referenced this issue Jul 22, 2013
@charles-dyfis-net
Merge pull request #5 from domurtag/master
6473169 
Fixes for #3 and #4 (locale dependence and thread-safety issues). Many thanks to @domurtag / @kaufda.
@elijahandrews
Copy link
Author

Thanks!

@charles-dyfis-net
Copy link

Fix released in 2.0.8; thank you for the report, and @kaufda for the fix.

@venth venth mentioned this issue Feb 20, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@charles-dyfis-net @elijahandrews