Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #3 and #4. I've included a regression test for #3. You can verify that this test reproduces #3 by temporarily changing line 58 of
NonBlockingStatsDClient
from:to
which is consistent with the previous version. After making this change the regression test will fail. Could you please make a new release ASAP after this pull request has been merged, because currently this library is not usable in any locale that uses something other than a period as the decimal separator (Germany, France, etc.).