Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tracing: vendored opentracing should not allow multiple HTTP header span propagation #14203

Closed
goller opened this issue Jun 26, 2019 · 0 comments · Fixed by #14204
Closed

tracing: vendored opentracing should not allow multiple HTTP header span propagation #14203

goller opened this issue Jun 26, 2019 · 0 comments · Fixed by #14204
Labels
area/client area/HTTP difficulty/low Resolving this issue should take a day or two. kind/bug

Comments

@goller
Copy link
Contributor

goller commented Jun 26, 2019

See opentracing/opentracing-go#159

We should update to version 1.1: https://github.com/opentracing/opentracing-go/releases/tag/v1.1.0
@goller goller added area/client area/HTTP difficulty/low Resolving this issue should take a day or two. kind/bug team/workloads labels Jun 26, 2019
goller added a commit that referenced this issue Jun 26, 2019
@goller
chore(vendor): update to opentracing 1.1.0
3d557e5 
Closes #14203
@goller goller mentioned this issue Jun 26, 2019
Merged
7 tasks
goller added a commit that referenced this issue Jun 26, 2019
@goller
fix client tracing propagation from doubly recording (#14204)
14e7daa 
Closes #14203

* chore(vendor): update to opentracing 1.1.0

* fix(http): finish client span

* fix(http): remove extra span injection
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/client area/HTTP difficulty/low Resolving this issue should take a day or two. kind/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix client tracing propagation from doubly recording influxdata/influxdb
1 participant
@goller