Skip to content
This repository has been archived by the owner on May 23, 2023. It is now read-only.

Should use Set() instead of Add() in HTTPHeadersCarrier #159

Closed
vetinari opened this issue Sep 25, 2017 · 2 comments
Closed

Should use Set() instead of Add() in HTTPHeadersCarrier #159

vetinari opened this issue Sep 25, 2017 · 2 comments

Comments

@vetinari
Copy link

When re-using an incoming http.Request, Add() will create a double header (i.e. result is a comma separated value), see also instana/go-sensor#40
@jeremyxu2010
Copy link
Contributor

+1

jeremyxu2010 added a commit to jeremyxu2010/opentracing-go that referenced this issue Aug 22, 2018
@jeremyxu2010
Update propagation.go
aead5d5 
Should use Set() instead of Add() in HTTPHeadersCarrier. see opentracing#159
This was referenced Aug 22, 2018
Merged
Merged
vetinari added a commit to vetinari/lightstep-tracer-go that referenced this issue Sep 7, 2018
@vetinari
fix double headers when reusing the *http.Request
b5282c2 
because of opentracing/opentracing-go#159
the headers in a reused *http.Request are appended instead of set
which results in headers like this after injecting the current span
context:
```
ot-tracer-spanid: 911775291efa49de,46fbd688b66dc96d
ot-tracer-traceid: 24080003fd414b3d,24080003fd414b3d
ot-tracer-sampled: true,true
```

With these double headers at least the java client is unable to
extract the current span context.
@vetinari vetinari mentioned this issue Sep 7, 2018
Closed
szuecs added a commit to szuecs/opentracing-go that referenced this issue Sep 7, 2018
@szuecs
Fix opentracing#159 with opentracing#191
e14b9d4
@tobias-bahls
Copy link

Such headers might cause OpenTracing implementations on the JVM throw an unchecked IllegalArgumentException, which is not handled properly in e.g. https://github.com/opentracing-contrib/java-web-servlet-filter.

yurishkuro pushed a commit that referenced this issue Sep 8, 2018
@jeremyxu2010 @yurishkuro
Use Set() instead of Add() in HTTPHeadersCarrier (#191)
6aa6feb 
Fixes #159
@Dieterbe Dieterbe mentioned this issue Oct 12, 2018
Closed
@goller goller mentioned this issue Jun 26, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vetinari @jeremyxu2010 @tobias-bahls