This repository has been archived by the owner on May 23, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 316
Should use Set() instead of Add() in HTTPHeadersCarrier #159
Comments
+1 |
jeremyxu2010
added a commit
to jeremyxu2010/opentracing-go
that referenced
this issue
Aug 22, 2018
Should use Set() instead of Add() in HTTPHeadersCarrier. see opentracing#159
This was referenced Aug 22, 2018
vetinari
added a commit
to vetinari/lightstep-tracer-go
that referenced
this issue
Sep 7, 2018
because of opentracing/opentracing-go#159 the headers in a reused *http.Request are appended instead of set which results in headers like this after injecting the current span context: ``` ot-tracer-spanid: 911775291efa49de,46fbd688b66dc96d ot-tracer-traceid: 24080003fd414b3d,24080003fd414b3d ot-tracer-sampled: true,true ``` With these double headers at least the java client is unable to extract the current span context.
szuecs
added a commit
to szuecs/opentracing-go
that referenced
this issue
Sep 7, 2018
Such headers might cause OpenTracing implementations on the JVM throw an unchecked |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
When re-using an incoming http.Request, Add() will create a double header (i.e. result is a comma separated value), see also instana/go-sensor#40
The text was updated successfully, but these errors were encountered: