Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorial is outdated: hermes create channel #2154

Closed
5 tasks
plafer opened this issue Apr 27, 2022 · 7 comments
Closed
5 tasks

Tutorial is outdated: hermes create channel #2154

plafer opened this issue Apr 27, 2022 · 7 comments
Assignees
Labels
I: guide Internal: issues with the Hermes guide
Milestone

Comments

@plafer
Copy link
Contributor

plafer commented Apr 27, 2022

Summary of Bug

According to the hermes tutorial, I should be able to run

hermes create channel ibc-0 ibc-1 --port-a transfer --port-b transfer

to create a client, connection and channel between chains ibc-0 and ibc-1. This current fails with error

error: Invalid value "ibc-1" for '<CONNECTION_A>': identifier ibc-1 has invalid length 5 must be between 10-64 characters

Version

v0.14.0

Steps to Reproduce

  1. Spawn two chains (I used basecoin chains)
  2. Make sure your hermes config knows about both chains
  3. Run hermes create channel ibc-0 ibc-1 --port-a transfer --port-b transfer
  4. Notice the aforementioned error

Acceptance Criteria

The hermes create channel command succeeds.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@romac
Copy link
Member

romac commented Apr 28, 2022

The guide is outdated, the syntax for create channel is now

hermes create channel [OPTIONS] --port-a <PORT_A> --port-b <PORT_B> <CHAIN_A> [CONNECTION_A]

ie. the second positional argument is now the connection id.

I will update the guide later today, thanks for noticing!

PS: I am more and more convinced that we should eventually (for v1) move away from positional arguments and use flags everywhere.

@romac romac changed the title Regression: hermes create channel Tutorial is outdated: hermes create channel Apr 28, 2022
@romac romac added the I: guide Internal: issues with the Hermes guide label Apr 28, 2022
@adizere
Copy link
Member

adizere commented Apr 28, 2022

PS: I am more and more convinced that we should eventually (for v1) move away from positional arguments and use flags everywhere.

++++1

@romac
Copy link
Member

romac commented Apr 28, 2022

@romac romac closed this as completed Apr 28, 2022
@romac
Copy link
Member

romac commented Apr 28, 2022

Output listed in the guide depends on #2158

@dylanschultzie
Copy link

@romac it appears the guide isn't updated still:
Screen Shot 2022-05-26 at 1 54 42 PM

@adizere
Copy link
Member

adizere commented Jun 1, 2022

I was just about to approve #2245. Then I found this strange thing.

If I open
https://hermes.informal.systems/tutorials/local-chains/relay-paths/create-new-path.html

I see the correct, up-to-date instructions:
Screenshot 2022-06-01 at 10 34 23

But this page is not consistent with the source code
https://github.com/informalsystems/ibc-rs/blob/b7fc78e99f189f3fcad836008720ccec788ed1ff/guide/src/tutorials/local-chains/relay-paths/create-new-path.md?plain=1#L3-L6

What am I missing?

@romac
Copy link
Member

romac commented Jun 1, 2022

I already pushed the guide update manually to gh-pages but we now need to merge this to update master so that the update will be kept for the next version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I: guide Internal: issues with the Hermes guide
Projects
No open projects
Status: Closed
Development

No branches or pull requests

4 participants