Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix workflow for publishing guide on release #2153

Merged
merged 1 commit into from
May 2, 2022
Merged

Fix workflow for publishing guide on release #2153

merged 1 commit into from
May 2, 2022

Conversation

romac
Copy link
Member

@romac romac commented Apr 27, 2022

Closes: #2152

PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@adizere
Copy link
Member

adizere commented Apr 28, 2022

Does this also close #2154 ?

adizere
adizere approved these changes May 2, 2022
View reviewed changes
Copy link
Member

@adizere adizere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pre-approve for testing with #2166

@romac romac marked this pull request as ready for review May 2, 2022 14:48
@romac romac requested a review from ancazamfir as a code owner May 2, 2022 14:48
@romac romac merged commit 4008165 into master May 2, 2022
@romac romac deleted the romac/fix-guide-deploy branch May 2, 2022 14:50
hu55a1n1 pushed a commit to hu55a1n1/hermes that referenced this pull request Sep 13, 2022
@romac
Fix workflow for publishing guide on release (informalsystems#2153)
6c71a03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adizere adizere adizere approved these changes

@ancazamfir ancazamfir Awaiting requested review from ancazamfir

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hermes guide does not deploy when release is created
2 participants
@romac @adizere