Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use manual Debug impl for ChannelId to show it as a string instead of a number #2158

Merged
merged 1 commit into from
Apr 28, 2022

Conversation

romac
Copy link
Member

@romac romac commented Apr 28, 2022

This reverts the formatting change introduced in b44ade9f8.

Before

channel_id: Some(
    ChannelId(
        2,
     ),
),

After

channel_id: Some(
    ChannelId(
        "channel-2",
    ),
),

PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@romac romac requested a review from hu55a1n1 April 28, 2022 11:20
@romac romac changed the title Use manual Debug impl for ChannelId to show it as a string instead of a struct Use manual Debug impl for ChannelId to show it as a string instead of a number Apr 28, 2022
@romac romac marked this pull request as draft April 28, 2022 11:23
@romac romac marked this pull request as ready for review April 28, 2022 11:26
Copy link
Member

@hu55a1n1 hu55a1n1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@romac romac merged commit ef92d3e into master Apr 28, 2022
@romac romac deleted the romac/channel-id-debug branch April 28, 2022 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants