Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use manual Debug impl for ChannelId to show it as a string instead of a number #2158

Merged
merged 1 commit into from
Apr 28, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions modules/src/core/ics24_host/identifier.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
use core::convert::{From, Infallible};
use core::fmt::{self, Display, Formatter};
use core::fmt::{self, Debug, Display, Formatter};
use core::str::FromStr;

use serde::{de, Deserialize, Deserializer, Serialize, Serializer};
Expand Down Expand Up @@ -335,7 +335,7 @@ impl Default for PortId {
}
}

#[derive(Copy, Clone, Debug, PartialEq, Eq, PartialOrd, Ord, Hash)]
#[derive(Copy, Clone, PartialEq, Eq, PartialOrd, Ord, Hash)]
pub struct ChannelId(u64);

impl ChannelId {
Expand Down Expand Up @@ -370,6 +370,12 @@ impl Display for ChannelId {
}
}

impl Debug for ChannelId {
fn fmt(&self, f: &mut Formatter<'_>) -> Result<(), fmt::Error> {
f.debug_tuple("ChannelId").field(&self.to_string()).finish()
}
}

impl FromStr for ChannelId {
type Err = ValidationError;

Expand Down