Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explore clippy rules and apply quality of life recommendations #122

Closed
wants to merge 57 commits into from
Closed

Explore clippy rules and apply quality of life recommendations #122

wants to merge 57 commits into from

Commits on Jan 3, 2020

  1. Set clippy rules in root

    @xla
    xla committed Jan 3, 2020
    Configuration menu
    Copy the full SHA
    b7e300f View commit details
    Browse the repository at this point in the history

  2. Remove Error prefix in kind enum

    @xla
    xla committed Jan 3, 2020
    Configuration menu
    Copy the full SHA
    f4bc257 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into xla/clippy

    @xla
    xla committed Jan 3, 2020
    Configuration menu
    Copy the full SHA
    04fec06 View commit details
    Browse the repository at this point in the history

  4. Remove superfluours Info suffix

    @xla
    xla committed Jan 3, 2020
    Configuration menu
    Copy the full SHA
    4d82f36 View commit details
    Browse the repository at this point in the history

  5. Remove superfluours Params suffix

    @xla
    xla committed Jan 3, 2020
    Configuration menu
    Copy the full SHA
    ae598b7 View commit details
    Browse the repository at this point in the history

  6. Remove superfluours Config suffix

    @xla
    xla committed Jan 3, 2020
    Configuration menu
    Copy the full SHA
    f1f4f9f View commit details
    Browse the repository at this point in the history

  7. Remove superfluours Id suffix

    @xla
    xla committed Jan 3, 2020
    Configuration menu
    Copy the full SHA
    6f423a7 View commit details
    Browse the repository at this point in the history

  8. Remove superfluours Version suffix

    @xla
    xla committed Jan 3, 2020
    Configuration menu
    Copy the full SHA
    e2220a1 View commit details
    Browse the repository at this point in the history

  9. Remove superfluous BlockId suffix

    @xla
    xla committed Jan 3, 2020
    Configuration menu
    Copy the full SHA
    2810c89 View commit details
    Browse the repository at this point in the history

  10. Remove superfluous Amino prefix

    @xla
    xla committed Jan 3, 2020
    Configuration menu
    Copy the full SHA
    faf0fe6 View commit details
    Browse the repository at this point in the history

  11. Remove superfluous Ping prefix

    @xla
    xla committed Jan 3, 2020
    Configuration menu
    Copy the full SHA
    827285e View commit details
    Browse the repository at this point in the history

  12. Remove superfluous RemoteError prefix

    @xla
    xla committed Jan 3, 2020
    Configuration menu
    Copy the full SHA
    17c7996 View commit details
    Browse the repository at this point in the history

  13. Remove superfluous RemoteError prefix

    @xla
    xla committed Jan 3, 2020
    Configuration menu
    Copy the full SHA
    2d7607d View commit details
    Browse the repository at this point in the history

  14. Lock down amino module surface

    @xla
    xla committed Jan 3, 2020
    Configuration menu
    Copy the full SHA
    5ddb642 View commit details
    Browse the repository at this point in the history

  15. Remove superfluous Time prefix

    @xla
    xla committed Jan 3, 2020
    Configuration menu
    Copy the full SHA
    7e3b87f View commit details
    Browse the repository at this point in the history

  16. Remove superfluous Vote suffix

    @xla
    xla committed Jan 3, 2020
    Configuration menu
    Copy the full SHA
    d3dc4b9 View commit details
    Browse the repository at this point in the history

  17. Remove superfluous Vote suffix

    @xla
    xla committed Jan 3, 2020
    Configuration menu
    Copy the full SHA
    61dce99 View commit details
    Browse the repository at this point in the history

  18. Use markdown emphasize & link for types

    @xla
    xla committed Jan 3, 2020
    Configuration menu
    Copy the full SHA
    a0c842f View commit details
    Browse the repository at this point in the history

  19. Use _ for literal suffix

    @xla
    xla committed Jan 3, 2020
    Configuration menu
    Copy the full SHA
    bad770b View commit details
    Browse the repository at this point in the history

  20. Make clippy rule exception for db names

    @xla
    xla committed Jan 3, 2020
    Configuration menu
    Copy the full SHA
    63c673c View commit details
    Browse the repository at this point in the history

  21. Remove print statements

    @xla
    xla committed Jan 3, 2020
    Configuration menu
    Copy the full SHA
    56d1f48 View commit details
    Browse the repository at this point in the history

  22. Replace similiar names

    @xla
    xla committed Jan 3, 2020
    Configuration menu
    Copy the full SHA
    7bf1093 View commit details
    Browse the repository at this point in the history

  23. Allow multiple crate versions 

    It's hard to avoid multiple crate versions given current transient
dependencies, some of them we control and we are following up to bring
most of them on par:

tendermint/amino_rs#20
    @xla
    xla committed Jan 3, 2020
    1 Configuration menu
    Copy the full SHA
    a01d234 View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2020

  1. Consolidate impl blocks

    @xla
    xla committed Jan 4, 2020
    Configuration menu
    Copy the full SHA
    41cbd02 View commit details
    Browse the repository at this point in the history

  2. Use Self consistently

    @xla
    xla committed Jan 4, 2020
    Configuration menu
    Copy the full SHA
    67f7358 View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2020

  1. Mark functions as const where possible

    @xla
    xla committed Jan 5, 2020
    Configuration menu
    Copy the full SHA
    0ee13e2 View commit details
    Browse the repository at this point in the history

  2. Unify matches with equal arm bodies

    @xla
    xla committed Jan 5, 2020
    Configuration menu
    Copy the full SHA
    37078c4 View commit details
    Browse the repository at this point in the history

  3. Remove unecessary closures

    @xla
    xla committed Jan 5, 2020
    Configuration menu
    Copy the full SHA
    834263c View commit details
    Browse the repository at this point in the history

  4. Remove possible truncation

    @xla
    xla committed Jan 5, 2020
    Configuration menu
    Copy the full SHA
    9b9e875 View commit details
    Browse the repository at this point in the history

  5. Remove possible truncation

    @xla
    xla committed Jan 5, 2020
    Configuration menu
    Copy the full SHA
    85100a3 View commit details
    Browse the repository at this point in the history

  6. Allow fallible from impls for now and leave todos

    @xla
    xla committed Jan 5, 2020
    4 Configuration menu
    Copy the full SHA
    71f0cd3 View commit details
    Browse the repository at this point in the history

  7. Replace enum glob use with proper qualified variants

    @xla
    xla committed Jan 5, 2020
    Configuration menu
    Copy the full SHA
    d3651c4 View commit details
    Browse the repository at this point in the history

  8. Allow integer arithmetic

    @xla
    xla committed Jan 5, 2020
    Configuration menu
    Copy the full SHA
    da3a7c9 View commit details
    Browse the repository at this point in the history

  9. Use proper division methoods on ints

    @xla
    xla committed Jan 5, 2020
    Configuration menu
    Copy the full SHA
    749c679 View commit details
    Browse the repository at this point in the history

  10. Allow index slicing

    @xla
    xla committed Jan 5, 2020
    Configuration menu
    Copy the full SHA
    c4d4c56 View commit details
    Browse the repository at this point in the history

  11. Allow index slicing

    @xla
    xla committed Jan 5, 2020
    Configuration menu
    Copy the full SHA
    21b2a8f View commit details
    Browse the repository at this point in the history

  12. Alllow default_trait_access mostly for defive

    @xla
    xla committed Jan 5, 2020
    Configuration menu
    Copy the full SHA
    15e37ca View commit details
    Browse the repository at this point in the history

Commits on Jan 7, 2020

  1. Allow sign loss for cast

    @xla
    xla committed Jan 7, 2020
    Configuration menu
    Copy the full SHA
    1144a4f View commit details
    Browse the repository at this point in the history

  2. Address wildcard enum matches

    @xla
    xla committed Jan 7, 2020
    Configuration menu
    Copy the full SHA
    d7ef18a View commit details
    Browse the repository at this point in the history

  3. Avoid warning for inline attribute

    @xla
    xla committed Jan 7, 2020
    Configuration menu
    Copy the full SHA
    85e57aa View commit details
    Browse the repository at this point in the history

  4. Ignore must use lint as it is only a recommendation

    @xla
    xla committed Jan 7, 2020
    Configuration menu
    Copy the full SHA
    d53540f View commit details
    Browse the repository at this point in the history

  5. Address missing docs

    @xla
    xla committed Jan 7, 2020
    Configuration menu
    Copy the full SHA
    ab338d7 View commit details
    Browse the repository at this point in the history

  6. Remove superfluous unwrap_or_else

    @xla
    xla committed Jan 7, 2020
    Configuration menu
    Copy the full SHA
    8534547 View commit details
    Browse the repository at this point in the history

  7. Address unwrap used on Options

    @xla
    xla committed Jan 7, 2020
    Configuration menu
    Copy the full SHA
    bd9b608 View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2020

  1. Replace result unwrap with expect

    @xla
    xla committed Jan 18, 2020
    Configuration menu
    Copy the full SHA
    5cfcb37 View commit details
    Browse the repository at this point in the history

  2. Rework use of unreachable

    @xla
    xla committed Jan 18, 2020
    Configuration menu
    Copy the full SHA
    255ba11 View commit details
    Browse the repository at this point in the history

  3. Remove use of panic

    @xla
    xla committed Jan 18, 2020
    Configuration menu
    Copy the full SHA
    3dbd0d8 View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2020

  1. Remove bare panics

    @xla
    xla committed Jan 20, 2020
    Configuration menu
    Copy the full SHA
    dd405fa View commit details
    Browse the repository at this point in the history

  2. Remove needles pass by value

    @xla
    xla committed Jan 20, 2020
    Configuration menu
    Copy the full SHA
    e90bc89 View commit details
    Browse the repository at this point in the history

  3. Replace explicit iter calls

    @xla
    xla committed Jan 20, 2020
    Configuration menu
    Copy the full SHA
    2b9b699 View commit details
    Browse the repository at this point in the history

  4. Remove needless borrows

    @xla
    xla committed Jan 20, 2020
    4 Configuration menu
    Copy the full SHA
    99e323c View commit details
    Browse the repository at this point in the history

  5. Address cast possible wrap

    @xla
    xla committed Jan 20, 2020
    Configuration menu
    Copy the full SHA
    7750986 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' into xla/clippy

    @xla
    xla committed Jan 20, 2020
    Configuration menu
    Copy the full SHA
    ab1e77a View commit details
    Browse the repository at this point in the history

  7. Add documentation for unit enum

    @xla
    xla committed Jan 20, 2020
    Configuration menu
    Copy the full SHA
    dfb094a View commit details
    Browse the repository at this point in the history

  8. Add cargo fields to lite crate

    @xla
    xla committed Jan 20, 2020
    Configuration menu
    Copy the full SHA
    3ebb516 View commit details
    Browse the repository at this point in the history

  9. Address lite merge follow-ups

    @xla
    xla committed Jan 20, 2020
    Configuration menu
    Copy the full SHA
    357a791 View commit details
    Browse the repository at this point in the history

  10. Address missing docs

    @xla
    xla committed Jan 20, 2020
    Configuration menu
    Copy the full SHA
    b2b5db7 View commit details
    Browse the repository at this point in the history