Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpc: ADR for client event subscription mechanism #476

Merged
merged 19 commits into from
Aug 28, 2020
Merged

rpc: ADR for client event subscription mechanism #476

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
e2e3581
Add first draft of ADR-008
thanethomson Jul 23, 2020
844af0c
Add comment about WebSockets connection
thanethomson Jul 24, 2020
16eb48f
Rename to "RPC Client" for greater clarity
thanethomson Jul 27, 2020
5101c03
Update docs/architecture/adr-008-event-subscription.md
thanethomson Aug 4, 2020
e0dcae9
Update to reflect work on #516
thanethomson Aug 19, 2020
12f008f
Leave out implementation details (ADR)
thanethomson Aug 19, 2020
f47d461
Clarify handle/driver concurrency model
thanethomson Aug 19, 2020
42e7fad
Update with latest architecture inspired by #516
thanethomson Aug 19, 2020
1884297
Condense Client trait example for readability
thanethomson Aug 27, 2020
80be41c
Reduce complexity of subscription interface
thanethomson Aug 27, 2020
4faedc6
Introduce ClosableClient trait
thanethomson Aug 27, 2020
18c7f84
Reduce number of client implementations
thanethomson Aug 27, 2020
c465ce8
Remove SubscriptionRouter from ADR discussion (it is an implementatio…
thanethomson Aug 27, 2020
0979380
Update ERD to reflect current architecture
thanethomson Aug 27, 2020
7008c07
Add note on bounded vs unbounded channels in subscriptions
thanethomson Aug 27, 2020
3304736
Fix link for async drop discussion
thanethomson Aug 27, 2020
b598a1a
Add more structure and explanation to the Subscription section
thanethomson Aug 27, 2020
0b07458
Add Subscription section on leveraging futures::stream utils
thanethomson Aug 27, 2020
d4ba7aa
Clarify ERD by using colours instead of line thickness
thanethomson Aug 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading