[Rails 5.1.0 Compatibility BugFix] Inserting middleware when catch_xml_errors is set to true

[bogdanRada]

Hello,
I was trying today to upgrade one of my projects to rails 5.1.0 , which depends to this gem and was failing with error: "No such middleware to insert after: "ActionDispatch::ShowExceptions",

The issue was that here: https://github.com/rails/rails/blob/master/actionpack/lib/action_dispatch/middleware/stack.rb#L104 , the check is done now on the class itself directly when rails tries to find the index of the middleware "ActionDispatch::ShowExceptions"

So strings are not working anymore when passing middlewares to insert_after in the stack, putting directly the class name instead works perfectly.

I tested this with other rails versions and seems to work fine also. Please let me know what you think.

Thank you very much.

[bogdanRada]

any updates on this? This is a roadblock for me and i can't update my applications to latest rails version because of this issue.

[jdsampayo]

+1 can we get this included?

[lostapathy]

@inossidabile thanks for merging #238. Can we merge this as well and then push a new build as 0.12.0 to rubygems? Many thanks!

[bogdanRada]

thank you very much also :)