fix travis build, add rails 5.1 to appraisal, and bump version #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any update on this? |
|
@lostapathy this will also include the bug fix for Rails' minitest plugin that was introduced in |
lostapathy
changed the title
|
@inossidabile or anyone else with commit access, what are next steps we can take to move forward with this patch? At least when I submitted it, it would fix the travis build. It also makes this gem work with Rails 5.1, which would be a big help for me. I also have patches for other projects that depend on wash_out that I'm holding until we can get this upstreamed. thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds rails 5.1.1 to the appraisal and travis configs. minitest was also locked to <5.10.0 because 5.10.0 was causing appraisal to fail even before I added rails 5.1.1 support.
I bumped the version in the gemspec and am requesting a new version be released once #234 is also merged. There are several of us (and some other libraries) that are in a holding pattern and running from forks until the other fixes in master are released.
If there is additional work that must be finished in order to cut a new gem version, please point me in the right direction, I'm glad to help.