Skip to content

Commit

Permalink
Improve strings (#53)
Browse files Browse the repository at this point in the history
* Clarify patch descriptions

* (YouTube): Capitalize proper nouns in settings

and other small string fixes

* (YouTube - Player flyout menu): Capitalize and quote strings

* Update src/main/resources/youtube/settings/host/values/strings.xml

Co-authored-by: KobeW50 <[email protected]>

* (YouTube): update strings.xml

* Make "For you shelves" singular

* Plural nouns in patch names and descriptions

* change the patch name in the `Patch information` section

* Update RecentlyVisitedShelfPatch.kt

---------

Co-authored-by: inotia00 <[email protected]>
  • Loading branch information
KobeW50 and inotia00 authored May 30, 2024
1 parent 32b033d commit fb1fd09
Show file tree
Hide file tree
Showing 15 changed files with 138 additions and 138 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import com.android.tools.smali.dexlib2.iface.instruction.TwoRegisterInstruction
@Suppress("unused")
object OldStyleLibraryShelfPatch : BaseBytecodePatch(
name = "Restore old style library shelf",
description = "Adds an option to return the library tab to the old style.",
description = "Adds an option to return the Library tab to the old style.",
dependencies = setOf(SettingsPatch::class),
compatiblePackages = COMPATIBLE_PACKAGE,
fingerprints = setOf(BrowseIdFingerprint)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ import com.android.tools.smali.dexlib2.iface.reference.Reference
@Suppress("unused")
object DislikeRedirectionPatch : BaseBytecodePatch(
name = "Disable dislike redirection",
description = "Adds an option to disable redirection to the next track when clicking the dislike button.",
description = "Adds an option to disable redirection to the next track when clicking the Dislike button.",
dependencies = setOf(SettingsPatch::class),
compatiblePackages = COMPATIBLE_PACKAGE,
fingerprints = setOf(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ import app.revanced.util.patch.BaseResourcePatch

@Suppress("unused")
object OpusCodecPatch : BaseResourcePatch(
name = "Enable opus codec",
description = "Adds an option to use the opus audio codec instead of the mp4a audio codec.",
name = "Enable OPUS codec",
description = "Adds an option to use the OPUS audio codec instead of the MP4A audio codec.",
dependencies = setOf(
OpusCodecBytecodePatch::class,
SettingsPatch::class
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@ import com.android.tools.smali.dexlib2.iface.reference.MethodReference

@Suppress("unused")
object ReplaceCastButtonPatch : BaseBytecodePatch(
name = "Replace cast button",
description = "Adds an option to replace the cast button in the player with the \"Open music\" button.",
name = "Replace Cast button",
description = "Adds an option to replace the Cast button in the player with an Open music button.",
dependencies = setOf(
MainActivityResolvePatch::class,
PlayerResponsePatch::class,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ import com.android.tools.smali.dexlib2.iface.reference.Reference

@Suppress("unused")
object RecentlyVisitedShelfPatch : BaseBytecodePatch(
name = "Hide recently visited shelf",
description = "Adds an option to hide the recently visited shelf in the sidebar.",
name = "Hide Recently Visited shelf",
description = "Adds an option to hide the Recently Visited shelf in the sidebar.",
dependencies = setOf(SettingsPatch::class),
compatiblePackages = COMPATIBLE_PACKAGE,
fingerprints = setOf(CommunityDrawerPresenterFingerprint)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import app.revanced.util.resultOrThrow
@Suppress("unused")
object ScreenshotPopupPatch : BaseBytecodePatch(
name = "Disable screenshot popup",
description = "Adds an option to disable the popup that shows up when taking a screenshot.",
description = "Adds an option to disable the popup that appears when taking a screenshot.",
dependencies = setOf(
SettingsPatch::class,
SharedResourceIdPatch::class
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import app.revanced.util.patch.BaseResourcePatch

@Suppress("unused")
object ShortsDimmingPatch : BaseResourcePatch(
name = "Hide shorts dimming",
name = "Hide Shorts dimming",
description = "Removes, at compile time, the dimming effect at the top and bottom of Shorts videos.",
dependencies = setOf(SettingsPatch::class),
compatiblePackages = COMPATIBLE_PACKAGE,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import app.revanced.util.patch.BaseResourcePatch
@Suppress("DEPRECATION", "unused")
object MaterialYouPatch : BaseResourcePatch(
name = "MaterialYou",
description = "Enables MaterialYou theme for Android 12+.",
description = "Applies the MaterialYou theme for Android 12+ devices.",
dependencies = setOf(
BaseThemePatch::class,
SettingsPatch::class,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ import com.android.tools.smali.dexlib2.iface.instruction.formats.Instruction3rc
@Suppress("unused")
object PlayerButtonsPatch : BaseBytecodePatch(
name = "Hide player buttons",
description = "Adds an option to hide buttons in the video player.",
description = "Adds options to hide buttons in the video player.",
dependencies = setOf(
CastButtonPatch::class,
FullscreenButtonViewStubPatch::class,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ import com.android.tools.smali.dexlib2.iface.instruction.OneRegisterInstruction

@Suppress("unused")
object CommentsComponentPatch : BaseBytecodePatch(
name = "Hide comments component",
name = "Hide comments components",
description = "Adds options to hide components related to comments.",
dependencies = setOf(
LithoFilterPatch::class,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import app.revanced.util.patch.BaseResourcePatch
@Suppress("unused")
object ShortsOutlineButtonPatch : BaseResourcePatch(
name = "Shorts outline button",
description = "Applies the outline icon to the action buttons in the Shorts player.",
description = "Applies, at compile time, the outline icon to the action buttons in the Shorts player.",
dependencies = setOf(SettingsPatch::class),
compatiblePackages = COMPATIBLE_PACKAGE
) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ import com.android.tools.smali.dexlib2.iface.instruction.ReferenceInstruction

@Suppress("unused")
object ShortsRepeatPatch : BaseBytecodePatch(
name = "Change shorts repeat state",
name = "Change Shorts repeat state",
description = "Adds an option to control whether Shorts should repeat, autoplay, or pause upon ending.",
dependencies = setOf(SettingsPatch::class),
compatiblePackages = COMPATIBLE_PACKAGE,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ import com.android.tools.smali.dexlib2.iface.reference.MethodReference

@Suppress("unused")
object ResumingShortsOnStartupPatch : BaseBytecodePatch(
name = "Disable resuming shorts on startup",
name = "Disable resuming Shorts on startup",
description = "Adds an option to disable the Shorts player from resuming on app startup when Shorts were last being watched.",
dependencies = setOf(SettingsPatch::class),
compatiblePackages = COMPATIBLE_PACKAGE,
Expand Down
Loading

0 comments on commit fb1fd09

Please sign in to comment.