-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve strings #53
Improve strings #53
Conversation
and other small string fixes
I only capitalized things things that have a label. To illustrate what I mean, here is what is written for the share button in the action button settings, the shorts player settings, and the quick action buttons settings: Action buttons: Shorts player: Quick actions: I did this because the quick action share button does not have label. But the other share buttons say "Share". |
Even if there is no label, it seems appropriate to capitalize it |
I'm having trouble deciding when to be consistent with this. There are many similar cases that feel wrong to capitalize or quote. Here's two examples, but there are MANY more:
Maybe we should only treat YouTube elements that have a definite name as proper nouns? So the quick action buttons can be treated as proper nouns (since we know exactly what the label would be, while a button like the voice search button would not be treated as a proper noun since there is no label for it anywhere). Another example where it isn't obvious how to treat a reference to a UI element:
|
Also, seems like 'Playables' was changed to 'playables' which can also be changed back. |
Co-authored-by: KobeW50 <[email protected]>
|
For the YTM |
According to Google's docs, codec is written in all capital letters, not just the first letter https://support.google.com/youtube/answer/4603579?hl=en&sjid=11348161076157132150-AP It seems appropriate to write MP4A in all capital letters as well |
Out of curiosity, is that file the config for the default settings? |
If you are talking about the Official Revanced also uses revanced_prefs.xml |
Since new strings will be added, I will merge the current PR branch for now to minimize commit conflicts Opens a new PR to complete unfinished work, including a new string |
This PR aims to:
Hide Comments by members banner
->Hide 'Comments by members' banner
)Closes inotia00/ReVanced_Extended#2051
TODO:
Hide recently visited shelf
patch (see here)