Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve strings #53

Merged
merged 10 commits into from
May 30, 2024
Merged

Improve strings #53

merged 10 commits into from
May 30, 2024

Conversation

KobeW50
Copy link
Collaborator

@KobeW50 KobeW50 commented May 27, 2024

This PR aims to:

  • Capitalize all proper nouns, such as "Shorts" (I probably missed a few)
  • Place quoted strings in quotes (example: Hide Comments by members banner -> Hide 'Comments by members' banner)
  • Fix minor issues in some patch descriptions and settings strings

Closes inotia00/ReVanced_Extended#2051

TODO:

  • YT Music in-app strings
  • Correctly name Reddit's Hide recently visited shelf patch (see here)

@KobeW50 KobeW50 marked this pull request as draft May 27, 2024 20:43
@KobeW50
Copy link
Collaborator Author

KobeW50 commented May 27, 2024

I only capitalized things things that have a label. To illustrate what I mean, here is what is written for the share button in the action button settings, the shorts player settings, and the quick action buttons settings:

Action buttons: Hide Share button

Shorts player: Hide Share button

Quick actions: Hide share button

I did this because the quick action share button does not have label. But the other share buttons say "Share".

@inotia00
Copy link
Owner

I only capitalized things things that have a label. To illustrate what I mean, here is what is written for the share button in the action button settings, the shorts player settings, and the quick action buttons settings:

Action buttons: Hide Share button

Shorts player: Hide Share button

Quick actions: Hide share button

I did this because the quick action share button does not have label. But the other share buttons say "Share".

Even if there is no label, it seems appropriate to capitalize it
A representative example is Hide Create button

@KobeW50
Copy link
Collaborator Author

KobeW50 commented May 28, 2024

I only capitalized things things that have a label. To illustrate what I mean, here is what is written for the share button in the action button settings, the shorts player settings, and the quick action buttons settings:
Action buttons: Hide Share button
Shorts player: Hide Share button
Quick actions: Hide share button
I did this because the quick action share button does not have label. But the other share buttons say "Share".

Even if there is no label, it seems appropriate to capitalize it A representative example is Hide Create button

I'm having trouble deciding when to be consistent with this. There are many similar cases that feel wrong to capitalize or quote. Here's two examples, but there are MANY more:

  1. Hide voice search button. It seems wrong to put this in single quotes, since there is no label for the button, and it also seems odd if it were only capitalized since it is two words.

Maybe we should only treat YouTube elements that have a definite name as proper nouns? So the quick action buttons can be treated as proper nouns (since we know exactly what the label would be, while a button like the voice search button would not be treated as a proper noun since there is no label for it anywhere).

Another example where it isn't obvious how to treat a reference to a UI element:

  1. In the RYD settings there is an option for Compact like button. Should such a thing be capitalized? The Hide Like button option treats the button as a proper noun. Is the same true here?

@ILoveOpenSourceApplications

Also, seems like 'Playables' was changed to 'playables' which can also be changed back.

@ILoveOpenSourceApplications
Copy link

ILoveOpenSourceApplications commented May 28, 2024

Sorting is also off in Video filter, Shorts player and Video settings. In Shorts player, under action buttons, I understand the order is similar to how the buttons are in the Shorts layout. But the other options should be sorted.

Edit: In feed settings:
Screenshot_20240528_125951_YouTube

@inotia00
Copy link
Owner

inotia00 commented May 28, 2024

I'm having trouble deciding when to be consistent with this. There are many similar cases that feel wrong to capitalize or quote. Here's two examples, but there are MANY more:

  1. Hide voice search button. It seems wrong to put this in single quotes, since there is no label for the button, and it also seems odd if it were only capitalized since it is two words.

Maybe we should only treat YouTube elements that have a definite name as proper nouns? So the quick action buttons can be treated as proper nouns (since we know exactly what the label would be, while a button like the voice search button would not be treated as a proper noun since there is no label for it anywhere).

Another example where it isn't obvious how to treat a reference to a UI element:

  1. In the RYD settings there is an option for Compact like button. Should such a thing be capitalized? The Hide Like button option treats the button as a proper noun. Is the same true here?
  1. In Google's docs, it is written as voice search (lowercase letters)
  2. In ReVanced, Compact like button is written in lowercase letters
    It seems that capitalization of proper nouns is not used in the sub-settings of SponsorBlock and Return YouTube Dislike

@KobeW50
Copy link
Collaborator Author

KobeW50 commented May 28, 2024

For the YTM Enable opus codec patch name and strings, it seems that Opus should be capitalized as it is on the official website, But I'm not sure about references to mp4a.

@inotia00
Copy link
Owner

According to Google's docs, codec is written in all capital letters, not just the first letter
(e.g. AV1, VP9, ​​AAC, MP3, OPUS)

https://support.google.com/youtube/answer/4603579?hl=en&sjid=11348161076157132150-AP
https://support.google.com/youtubemusic/answer/9076559?hl=en

It seems appropriate to write MP4A in all capital letters as well

@KobeW50
Copy link
Collaborator Author

KobeW50 commented May 30, 2024

Out of curiosity, is that file the config for the default settings?

@inotia00
Copy link
Owner

If you are talking about the revanced_prefs.xml file, yeah, it contains information about Revanced settings

Official Revanced also uses revanced_prefs.xml
(For official Revanced, revanced_prefs.xml is updated during the patch process)

@inotia00
Copy link
Owner

Since new strings will be added, I will merge the current PR branch for now to minimize commit conflicts

Opens a new PR to complete unfinished work, including a new string

@inotia00 inotia00 marked this pull request as ready for review May 30, 2024 09:56
@inotia00 inotia00 merged commit fb1fd09 into inotia00:dev May 30, 2024
@KobeW50 KobeW50 deleted the dev branch May 30, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants