Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: PlutusData to NftMetadata #805

Merged
merged 5 commits into from
Jul 10, 2023
Merged

feat: PlutusData to NftMetadata #805

merged 5 commits into from
Jul 10, 2023

Conversation

mkazlauskas
Copy link
Member

Context

In order to support cip68/222 NFT metadata we need to have a mapper from our core PlutusData type

Proposed Solution

See commits

@mkazlauskas mkazlauskas requested review from rhyslbw, iadmytro and a team July 5, 2023 15:29
@mkazlauskas mkazlauskas force-pushed the feat/plutus-data-to-cip25 branch 2 times, most recently from d4d25ba to cbc38ed Compare July 5, 2023 16:02
AngelCastilloB
AngelCastilloB approved these changes Jul 6, 2023
View reviewed changes
Copy link
Member

@AngelCastilloB AngelCastilloB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rhyslbw rhyslbw marked this pull request as draft July 6, 2023 16:01
@rhyslbw rhyslbw marked this pull request as ready for review July 10, 2023 09:10
@rhyslbw rhyslbw self-requested a review July 10, 2023 09:46
rhyslbw
rhyslbw approved these changes Jul 10, 2023
View reviewed changes
Copy link
Member

@rhyslbw rhyslbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @mkazlauskas 🚀

@mkazlauskas mkazlauskas force-pushed the feat/plutus-data-to-cip25 branch 2 times, most recently from 083c5d6 to 5403772 Compare July 10, 2023 09:53
@mkazlauskas
refactor!: hoist metadatumToCip25 to NftMetadata.fromMetadatum
76a9fcf 
NftMetadata type shouldn't be coupled to cip25, because there are
now 2 sources for NFT metadata:
- cip25: auxiliary data (tx metadata)
- cip68/222: datum
@mkazlauskas
refactor(core): loosen arg type of isPlutusData utils to accept 'unkn…
7b09c4a 
…own'
@mkazlauskas
feat(core): add hexToBytes, utf8ToBytes, utf8ToHex utils
71e6c55
@mkazlauskas mkazlauskas merged commit 31128fd into feat/plutus-data-serialization Jul 10, 2023
@mkazlauskas mkazlauskas deleted the feat/plutus-data-to-cip25 branch July 10, 2023 12:40
@mkazlauskas mkazlauskas mentioned this pull request Jul 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AngelCastilloB AngelCastilloB AngelCastilloB approved these changes

@rhyslbw rhyslbw rhyslbw approved these changes

@iadmytro iadmytro Awaiting requested review from iadmytro

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mkazlauskas @rhyslbw @AngelCastilloB