feat: nft metadata service #769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkazlauskas
force-pushed
the
feat/plutus-data-serialization
branch
5 times, most recently
from
32c63a4
to
46185ad
Compare
mkazlauskas
force-pushed
the
feat/plutus-data-serialization
branch
2 times, most recently
from
f4c3d50
to
f138615
Compare
AngelCastilloB
previously approved these changes
Jun 15, 2023
rhyslbw
previously approved these changes
Jun 15, 2023
There was a problem hiding this comment.
Great work @mkazlauskas, can squash, but let's hold on merging until the #634
mkazlauskas
force-pushed
the
feat/plutus-data-serialization
branch
from
42f3708
to
191eb8f
Compare
mkazlauskas
force-pushed
the
feat/plutus-data-serialization
branch
2 times, most recently
from
ebfb09d
to
b58aa9d
Compare
mkazlauskas
changed the title
mkazlauskas
force-pushed
the
feat/plutus-data-serialization
branch
2 times, most recently
from
df729b0
to
05fb0cc
Compare
mkazlauskas
force-pushed
the
feat/plutus-data-serialization
branch
from
05fb0cc
to
9709fc7
Compare
mkazlauskas
force-pushed
the
feat/plutus-data-serialization
branch
from
4f4af9d
to
a85b1b0
Compare
AngelCastilloB
force-pushed
the
feat/plutus-data-serialization
branch
from
f61cd46
to
c078a91
Compare
AngelCastilloB
temporarily deployed
to
dev-preview
GitHub Actions
Inactive
AngelCastilloB
force-pushed
the
feat/plutus-data-serialization
branch
from
a8b98b2
to
c078a91
Compare
also clean up the test by removing duplicate data
there can be multiple 'copies' of nft metadata for an asset in a block it was keeping the 1st one instead
hoist from NftMetadata.fromPlutusData and add tests
it maps 'og' from base nft metadata and images from 'extra'
…mentations - hoist assetNameToUTF8Handle to util.ts - use AssetName.toUTF8 core util also, replace custom error with the existing InvalidStringError, because it wasn't used anywhere
hoist shared utils to util.ts
…rPaymentCredential columns
also add missing entity inter-dependency output->tokens
it would omit the prop if no stake pools of some status are in the database
in reality those shouldn't be in user's wallet, but technically they can be
to be used when generating cardano-services db snapshot
add a cip68 handle to handle test db disable some flaky tests: there are no 'retiring' pools in db fix TypeormStakePoolProvider test setup to match partial strings
address could also be owned by script
…prop it does not add any new columns, but simplifies queries
in some cases it returned a Buffer, because Buffer.valueOf() => Buffer in nodejs
Buffer is Node.js-specific ArrayBuffer and it's views is available in web environments as well
mkazlauskas
force-pushed
the
feat/plutus-data-serialization
branch
from
4be97d5
to
78460d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FEATURE BRANCH
In addition to Context below, it has:
Context for original scope
feat: add PlutusData core typesPlutusData (datums & redeemers) are currently typed as HexBlob. We need to create better types in order to be able to parse/interpret and build them.
Breaking changes
commit hashes below are outdated
9c39bbd- this is a major breaking change. Provider server is backward and forward incompatible.e024c9ecb6bc4e