Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ogmiosToCore auxiliary data map #820

Merged
merged 1 commit into from
Jul 18, 2023
Merged

fix: ogmiosToCore auxiliary data map #820

merged 1 commit into from
Jul 18, 2023

Conversation

mkazlauskas
Copy link
Member

Context

ogmiosToCore is not mapping auxiliaryData correctly: map has an additional layer of nesting

Proposed Solution

  • fix ogmiosToCore by implementing a new metadatum mapping function
  • update test data that was previously created with golden-test-generator

Note

Merge target is feat/plutus-data-serialization to preserve linear commit history

@mkazlauskas
fix: correct ogmiosToCore auxiliaryData mapping
49f9af3 
ogmiosToCore used jsonToMetadatum util, which mapping json
that is of different format from ogmios schema
@mkazlauskas mkazlauskas changed the title fix: ogmios to core auxiliary data map fix: ogmiosToCore auxiliary data map Jul 18, 2023
rhyslbw
rhyslbw approved these changes Jul 18, 2023
View reviewed changes
Copy link
Member

@rhyslbw rhyslbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @mkazlauskas 💪

@rhyslbw rhyslbw merged commit 6880f78 into feat/plutus-data-serialization Jul 18, 2023
3 checks passed
@rhyslbw rhyslbw deleted the fix/ogmios-to-core-auxiliary-data-map branch July 18, 2023 08:46
@mkazlauskas mkazlauskas mentioned this pull request Jul 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhyslbw rhyslbw rhyslbw approved these changes

@greatertomi greatertomi greatertomi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mkazlauskas @rhyslbw @greatertomi