feat: project missing handle props #905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
that can be used to look up the label and decoded value by asset id
to not clash with Handle type from core package
fix a bug where it would incorrectly map cip68 handle names by including label as part of the Handle also, add optional 'logger' parameter to 'withHandles' operator (to be converted to required) BREAKING CHANGE: withHandles now requires WithCIP67 props in
also clean up the test by removing duplicate data
mkazlauskas
force-pushed
the
feat/project-missing-handle-props
branch
2 times, most recently
from
6ffde67
to
d1cf475
Compare
mkazlauskas
commented
Sep 6, 2023
packages/cardano-services/src/StakePool/TypeormStakePoolProvider/mappers.ts
Show resolved
Hide resolved
mkazlauskas
commented
Sep 6, 2023
packages/cardano-services/test/ChainHistory/ChainHistoryHttpService.test.ts
Show resolved
Hide resolved
there can be multiple 'copies' of nft metadata for an asset in a block it was keeping the 1st one instead
hoist from NftMetadata.fromPlutusData and add tests
mkazlauskas
force-pushed
the
feat/project-missing-handle-props
branch
2 times, most recently
from
b8c3f02
to
f097bb4
Compare
rhyslbw
requested changes
Sep 7, 2023
There was a problem hiding this comment.
Great work here @mkazlauskas 🧙♂️
It's possible this will address the discrepancy @VanessaPC found when comparing results of our projection vs the Kora Labs API right?
packages/projection/src/operators/Mappers/withHandleMetadata.ts
Outdated
Show resolved
Hide resolved
rhyslbw
approved these changes
Sep 7, 2023
it maps 'og' from base nft metadata and images from 'extra'
…mentations - hoist assetNameToUTF8Handle to util.ts - use AssetName.toUTF8 core util also, replace custom error with the existing InvalidStringError, because it wasn't used anywhere
hoist shared utils to util.ts
…rPaymentCredential columns
mkazlauskas
force-pushed
the
feat/project-missing-handle-props
branch
from
446ce7b
to
37e7fec
Compare
iccicci
approved these changes
Sep 11, 2023
also add missing entity inter-dependency output->tokens
it would omit the prop if no stake pools of some status are in the database
in reality those shouldn't be in user's wallet, but technically they can be
to be used when generating cardano-services db snapshot
add a cip68 handle to handle test db disable some flaky tests: there are no 'retiring' pools in db fix TypeormStakePoolProvider test setup to match partial strings
address could also be owned by script
…prop it does not add any new columns, but simplifies queries
mkazlauskas
force-pushed
the
feat/project-missing-handle-props
branch
from
a1061ae
to
559f57d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
TypeormHandleProvider can't resolve some required handle properties:
LW-6928
Proposed Solution
See commit log
Important Changes Introduced