API simplification

[pawelru]

Here is the list of planned actions (don't confuse with suggestions). This list might grow once we agree on other "unresolved" yet parts of the teal. The whole point of this milestone is to simplify API by:

• making it easy to call the teal app.
• making it easy to apply teal components to any shiny app.

1. Simplify teal components

Final objective for first iteration of the API simplification is to call following module:

tm_module_srv <- function(data <list of reactives or list of data.frames>, filter_panel <filterPanelAPI>) {
  initial_chunks <- reactive({
    chunks_new(env = data, expr = get_expr(data))
  })
  ...
  extracts <- data_extract_srv(data, ...)
  merged_call <- data_merge_srv(extracts, get_join_keys(data), ...)
  
  another_chunk <- reactive({
    chunks_push(merged_call())
  })
  ...
  
  show_rcode(expr = final_chunk$get_expr())
}

To allow above model, we need to provide list of data.frames (or MAE) to data argument instead of passing datasets (FilteredData)

# somewhere in teal::init
data <- lapply(<module datanames>, FilteredData$get_reactive_data)

Another objective is to remove TealData frrom FilteredData dependencies.

• FIlteredData should not depend on the TealData/TealDataset.
• teal_module(s) should not depend on the FIlteredData

During the refactor we need to make sure that we won't break everything. I suggest to still send FilteredData if the datasets argument is used in the module.

• Make a show_rcode module teal.widgets#30
• Change constructor of the FilteredData to not depend on TealData teal.slice#33
• Remove teal.transform dependency on the FilteredData and chunks
  • data_merge - remove dependency on FilteredData and chunks. teal.transform#61
  • data_extract - remove dependency on datasets teal.transform#67
  • Remove dependency on teal.data teal.transform#68
• Pass the list of reactive data to the module. teal#654
• Extend constructor to allow chunks with initial ("evaluated") code and environment  teal.code#32
• Don't use datasets argument anymore
  • Change modules to use data argument instead of datasets teal.modules.general#402
  • Change modules to use data argument instead of datasets teal.modules.clinical#488
  • Change modules to use data argument instead of datasets teal.osprey#145
  • Change modules to use data argument instead of datasets teal.goshawk#152
  • Change modules to use data argument instead of datasets teal.modules.hermes#247
• Deprecate datasets in teal teal#656
• Pass filter_panel_api to the module teal.slice#64
• optional reporter in the independent teal modules teal#678

[nikolas-burkoff]

Can we also add simplifications such as insightsengineering/teal.transform#2 (or a replacement of it) and also possibly the equivalent for tmc (moving the data model out of the modules and into the cdisc object) so that specifying applications becomes significantly easier

[kpagacz]

+1 on simplifying des

[donyunardi]

Move insightsengineering/teal/issues/656 and insightsengineering/teal/issues/678 to #50
Closing.