Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change modules to use data argument instead of datasets #402

Closed
Tracked by #2
gogonzo opened this issue Jun 2, 2022 · 2 comments
Closed
Tracked by #2

Change modules to use data argument instead of datasets #402

gogonzo opened this issue Jun 2, 2022 · 2 comments
Assignees
Labels

Comments

@gogonzo
Copy link
Contributor

gogonzo commented Jun 2, 2022

Followup to:

Required fixes:

  • Remove datasets argument and introduce data argument.
  • Use new data_extract and data_merge
@gogonzo
Copy link
Contributor Author

gogonzo commented Jul 11, 2022

tm_datatable and tm_variable browser uses filtered and unfiltered data which means that data is insufficient for them. We need to discuss possible solutions:

  • data to contain filtered and unfiltered data.
  • passing unfiltered data to the FilteredDataAPI.
  • keep datasets in these modules.

@gogonzo
Copy link
Contributor Author

gogonzo commented Aug 16, 2022

We will need to do following item to complete tmg::tm_variable_browser and tm_data_table. But we can address this later, so it's not a blocker for the issue

insightsengineering/teal.slice#84

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants