Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optional reporter in the independent teal modules #678

Open
Tracked by #50
Polkas opened this issue Jun 28, 2022 · 2 comments
Open
Tracked by #50

optional reporter in the independent teal modules #678

Polkas opened this issue Jun 28, 2022 · 2 comments
Assignees
Labels

Comments

@Polkas
Copy link
Contributor

Polkas commented Jun 28, 2022

The reporter UI should be added to the module UI only if needed.
This will make the modules more suited when used independently, outside the NEST.
Another thing is that is we have a reporter in the server function so we need to think how it will influence an independent app. What if the reporter is not provided, we need some conditional on the server part too.
We magically inject the reporter to the server function in the teal app which will not be true for the independent app.

@Polkas Polkas added the core label Jun 28, 2022
@nikolas-burkoff
Copy link
Contributor

Note is_reporter_used is likely to be refactored very soon #674 (comment)

@Polkas Polkas self-assigned this Jun 28, 2022
@Polkas Polkas changed the title optional reporter UI in the teal modules optional reporter in the teal modules Jun 28, 2022
@Polkas Polkas removed their assignment Jun 28, 2022
@Polkas Polkas changed the title optional reporter in the teal modules optional reporter in the independent teal modules Jun 28, 2022
@Polkas
Copy link
Contributor Author

Polkas commented Jun 28, 2022

The scope is bigger than I expected, the server part have to be tackle here too. I am leaving it for later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants