Skip to content

Commit

Permalink
Adds min package version (#582)
Browse files Browse the repository at this point in the history
WIP :: parent issue:
insightsengineering/nestdevs-tasks#7

Supersede:
- #517 

### 🔴 Checklist for PR Reviewer

- [ ] Tag yourself next to this repo on
insightsengineering/nestdevs-tasks#7
- [ ] Package versions are the same or higher than `main`
- [ ] Package list is the same
- [ ] All packages in `Imports`, `Depends` & `Suggests` are in new
section `Config/Needs/verdepcheck`
- [ ] Added entry to `NEWS.md`
- [ ] Last `scheduled.yaml` action was run succesfully _(all 4
strategies)_
- important: it's not the last commit, it's the one that runs 4
`Scheduled 🕰️ / Dependency` actions
- [ ] `scheduled.yaml` SHOULD NOT have any push on any branches

### 🔴 What's needed before merging?

This PR depends on some upstream changes that need to be
finalized/merged before being ready to review.

#### Change in code

* `verdepcheck.yml` action (see comments)
  - [x] Remove `on: push` section 
  - [x] Change branch to main

#### PRS

- [ ] verdepcheck
  * insightsengineering/verdepcheck#24
  * insightsengineering/verdepcheck#26
- [ ] verdepcheck-action
  * insightsengineering/r-verdepcheck-action#16

### Changes description

* Adds minimum version for packages `DESCRIPTION`
* Adds `Config/Need/verdepcheck` section in `DESCRIPTION`
* Updates verdepcheck action
  • Loading branch information
averissimo authored Dec 18, 2023
1 parent 42ade6f commit 5073136
Show file tree
Hide file tree
Showing 3 changed files with 64 additions and 16 deletions.
23 changes: 23 additions & 0 deletions .github/workflows/scheduled.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
---
name: Scheduled 🕰️

on:
schedule:
- cron: '45 3 * * 0'
workflow_dispatch:

jobs:
dependency-test:
strategy:
fail-fast: false
matrix:
test-strategy: ["min_cohort", "min_isolated", "release", "max"]
uses: insightsengineering/r.pkg.template/.github/workflows/verdepcheck.yaml@main
name: Dependency Test - ${{ matrix.test-strategy }} 🔢
secrets:
REPO_GITHUB_TOKEN: ${{ secrets.REPO_GITHUB_TOKEN }}
GCHAT_WEBHOOK: ${{ secrets.GCHAT_WEBHOOK }}
with:
strategy: ${{ matrix.test-strategy }}
additional-env-vars: |
PKG_SYSREQS_DRY_RUN=true
54 changes: 39 additions & 15 deletions DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -23,33 +23,33 @@ BugReports: https://github.com/insightsengineering/chevron/issues
Depends:
R (>= 4.0.0)
Imports:
checkmate (>= 2.0),
dplyr,
checkmate (>= 2.1.0),
dplyr (>= 1.1.0),
dunlin (>= 0.1.6.9002),
forcats (>= 1.0.0),
formatters (>= 0.5.4),
ggplot2 (>= 3.4.0),
glue,
glue (>= 1.0.0),
grid,
lifecycle,
magrittr,
lifecycle (>= 0.2.0),
magrittr (>= 1.5),
methods,
nestcolor (>= 0.1.1),
purrr,
rlang,
purrr (>= 0.3.0),
rlang (>= 1.0.0),
rlistings (>= 0.2.6),
rtables (>= 0.6.5),
stringr,
stringr (>= 1.4.1),
tern (>= 0.9.2),
tibble,
tibble (>= 2.0.0),
utils
Suggests:
knitr,
rmarkdown,
testthat (>= 3.0.0),
tidyr,
vdiffr,
withr
knitr (>= 1.42),
rmarkdown (>= 2.19),
testthat (>= 3.0.4),
tidyr (>= 0.8.3),
vdiffr (>= 1.0.0),
withr (>= 2.1.0)
VignetteBuilder:
knitr
Remotes:
Expand All @@ -59,6 +59,30 @@ Remotes:
insightsengineering/rlistings@*release,
insightsengineering/rtables@*release,
insightsengineering/tern@*release
Config/Needs/verdepcheck:
mllg/checkmate,
tidyverse/dplyr,
insightsengineering/dunlin,
tidyverse/forcats,
insightsengineering/formatters,
tidyverse/ggplot2,
tidyverse/glue,
r-lib/lifecycle,
tidyverse/magrittr,
insightsengineering/nestcolor,
tidyverse/purrr,
r-lib/rlang,
insightsengineering/rlistings,
insightsengineering/rtables,
tidyverse/stringr,
insightsengineering/tern,
tidyverse/tibble,
yihui/knitr,
rstudio/rmarkdown,
r-lib/testthat,
tidyverse/tidyr,
r-lib/vdiffr,
r-lib/withr
Config/Needs/website: insightsengineering/nesttemplate
Config/testthat/edition: 3
Encoding: UTF-8
Expand Down
3 changes: 2 additions & 1 deletion NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
* Rename the dataset `ADAETTE` in `syn_data` object to `ADSAFTTE`.
* Use uppercase variable names in `AET05` and `AET05_ALL`.
* The string replacing `NA` values in the tables is now controlled by the `tern_default_na_str` option set during package load.
* Specified minimal version of package dependencies.

# chevron 0.2.4

Expand Down Expand Up @@ -68,7 +69,7 @@ switched.

# chevron 0.2.0

* Remove the usage of `dm` class of object. The chevron functions now expect list of `data.frame` as `adam_db` argument.
* Remove the usage of `dm` class of object. The chevron functions now expect list of `data.frame` as `adam_db` argument.
* Remove variants in template names.
* Remove deprecated `getter` functions `get_main`, `get_preprocess` and `get_postprocess`.
* Simplify `pre` function and add more data checks in `main` function.
Expand Down

0 comments on commit 5073136

Please sign in to comment.