Supports new strategies min_isolated and min_cohort
#16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 18, 2023
This was referenced Jul 26, 2023
pawelru
approved these changes
Aug 30, 2023
averissimo
added a commit
to insightsengineering/r.pkg.template
that referenced
this pull request
Aug 30, 2023
WIP :: parent issue: insightsengineering/nestdevs-tasks#7 ### 🔴 What's needed before merging? This PR depends on some upstream changes that need to be finalized before being ready to review. #### Change in code - [x] Change branch in verdepcheck-action from `new-strategies` back to `@main` #### PRS - [x] verdepcheck * insightsengineering/verdepcheck#24 * insightsengineering/verdepcheck#26 - [x] verdepcheck-action * insightsengineering/r-verdepcheck-action#16 ### Changes description * Documentation update on strategy, replacing `min` with `min_isolate` and `min_cohort`
This was referenced Sep 1, 2023
kartikeyakirar
pushed a commit
to insightsengineering/teal.reporter
that referenced
this pull request
Sep 5, 2023
WIP :: parent issue: insightsengineering/nestdevs-tasks#7 Supersede: * #189 ### 🔴 Checklist for PR Reviewer - [x] Tag yourself next to this repo on insightsengineering/nestdevs-tasks#7 - [x] Package versions are the same or higher than `main` - [x] Package list is the same - Only exception is `rmarkdown` (may have been removed on `Suggests`) - [x] All packages in `Imports`, `Depends` & `Suggests` are in new section `Config/Needs/verdepcheck` - [x] Added entry to `NEWS.md` - [x] Last `scheduled.yaml` action was run succesfully _(all 4 strategies)_ - important: it's not the last commit, it's the one that runs 4 `Scheduled 🕰️ / Dependency` actions - [x] `scheduled.yaml` SHOULD NOT have any push on any branches ### 🔴 What's needed before merging? This PR depends on some upstream changes that need to be finalized/merged before being ready to review. #### Change in code * `verdepcheck.yml` action (see comments) - [x] Remove `on: push` section - [x] Change branch to main #### PRS - [x] verdepcheck * insightsengineering/verdepcheck#24 * insightsengineering/verdepcheck#26 - [x] verdepcheck-action * insightsengineering/r-verdepcheck-action#16 ### Changes description * Adds minimum version for packages `DESCRIPTION` * Adds `Config/Need/verdepcheck` section in `DESCRIPTION` * Updates verdepcheck action
averissimo
added a commit
to insightsengineering/teal.code
that referenced
this pull request
Sep 5, 2023
WIP :: parent issue: insightsengineering/nestdevs-tasks#7 Supersede: * #104 ### 🔴 Checklist for PR Reviewer - [x] Tag yourself next to this repo on insightsengineering/nestdevs-tasks#7 - [x] Package versions are the same or higher than `main` - [x] Package list is the same - Only exception is `rmarkdown` (on `Suggests`) - [x] All packages in `Imports`, `Depends` & `Suggests` are in new section `Config/Needs/verdepcheck` - [x] Added entry to `NEWS.md` - [x] Last `scheduled.yaml` action was run succesfully _(all 4 strategies)_ - important: it's not the last commit, it's the one that runs 4 `Scheduled 🕰️ / Dependency` actions - [x] `scheduled.yaml` SHOULD NOT have any push on any branches ### 🔴 What's needed before merging? This PR depends on some upstream changes that need to be finalized/merged before being ready to review. #### Change in code * `verdepcheck.yml` action (see comments) - [x] Remove `on: push` section - [x] Change branch to main #### PRS - [x] verdepcheck * insightsengineering/verdepcheck#24 * insightsengineering/verdepcheck#26 - [x] verdepcheck-action * insightsengineering/r-verdepcheck-action#16 ### Changes description * Adds minimum version for packages `DESCRIPTION` * Adds `Config/Need/verdepcheck` section in `DESCRIPTION` * Updates verdepcheck action --------- Signed-off-by: André Veríssimo <[email protected]> Co-authored-by: Aleksander Chlebowski <[email protected]>
averissimo
added a commit
to insightsengineering/teal.data
that referenced
this pull request
Sep 5, 2023
WIP :: parent issue: insightsengineering/nestdevs-tasks#7 Supersede: * #148 ### 🔴 Checklist for PR Reviewer - [x] Tag yourself next to this repo on insightsengineering/nestdevs-tasks#7 - [x] Package versions are the same or higher than `main` - [x] Package list is the same - Only exception is `rmarkdown` (may have been removed on `Suggests`) - [x] All packages in `Imports`, `Depends` & `Suggests` are in new section `Config/Needs/verdepcheck` - [x] Added entry to `NEWS.md` - [x] Last `scheduled.yaml` action was run succesfully _(all 4 strategies)_ - important: it's not the last commit, it's the one that runs 4 `Scheduled 🕰️ / Dependency` actions - [x] `scheduled.yaml` SHOULD NOT have any push on any branches ### 🔴 What's needed before merging? This PR depends on some upstream changes that need to be finalized/merged before being ready to review. #### Change in code * `verdepcheck.yml` action (see comments) - [x] Remove `on: push` section - [x] Change branch to main #### PRS - [x] verdepcheck * insightsengineering/verdepcheck#24 * insightsengineering/verdepcheck#26 - [x] verdepcheck-action * insightsengineering/r-verdepcheck-action#16 ### Changes description * Adds minimum version for packages `DESCRIPTION` * Adds `Config/Need/verdepcheck` section in `DESCRIPTION` * Updates verdepcheck action --------- Signed-off-by: André Veríssimo <[email protected]> Co-authored-by: Aleksander Chlebowski <[email protected]>
averissimo
added a commit
to insightsengineering/teal.transform
that referenced
this pull request
Sep 5, 2023
WIP :: parent issue: insightsengineering/nestdevs-tasks#7 Supersede: * #137 ### 🔴 Checklist for PR Reviewer - [x] Tag yourself next to this repo on insightsengineering/nestdevs-tasks#7 - [x] Package versions are the same or higher than `main` - [x] Package list is the same - Only exception is `rmarkdown` (may have been removed on `Suggests`) - [x] All packages in `Imports`, `Depends` & `Suggests` are in new section `Config/Needs/verdepcheck` - [x] Added entry to `NEWS.md` - [x] Last `scheduled.yaml` action was run succesfully _(all 4 strategies)_ - important: it's not the last commit, it's the one that runs 4 `Scheduled 🕰️ / Dependency` actions - [x] `scheduled.yaml` SHOULD NOT have any push on any branches ### 🔴 What's needed before merging? This PR depends on some upstream changes that need to be finalized/merged before being ready to review. #### Change in code * `verdepcheck.yml` action (see comments) - [x] Remove `on: push` section - [x] Change branch to main #### PRS - [x] verdepcheck * insightsengineering/verdepcheck#24 * insightsengineering/verdepcheck#26 - [x] verdepcheck-action * insightsengineering/r-verdepcheck-action#16 ### Changes description * Adds minimum version for packages `DESCRIPTION` * Adds `Config/Need/verdepcheck` section in `DESCRIPTION` * Updates verdepcheck action --------- Signed-off-by: André Veríssimo <[email protected]> Co-authored-by: Aleksander Chlebowski <[email protected]>
averissimo
added a commit
to insightsengineering/teal.widgets
that referenced
this pull request
Sep 6, 2023
WIP :: parent issue: insightsengineering/nestdevs-tasks#7 Supersede: * https://github.com/insightsengineering/teal.logger/pull/159 ### 🔴 Checklist for PR Reviewer - [ ] Tag yourself next to this repo on insightsengineering/nestdevs-tasks#7 - [ ] Package versions are the same or higher than `main` - [ ] Package list is the same - Only exception is `rmarkdown` (may have been removed on `Suggests`) - [ ] All packages in `Imports`, `Depends` & `Suggests` are in new section `Config/Needs/verdepcheck` - [ ] Added entry to `NEWS.md` - [ ] Last `scheduled.yaml` action was run succesfully _(all 4 strategies)_ - important: it's not the last commit, it's the one that runs 4 `Scheduled 🕰️ / Dependency` actions - [ ] `scheduled.yaml` SHOULD NOT have any push on any branches ### 🔴 What's needed before merging? This PR depends on some upstream changes that need to be finalized/merged before being ready to review. #### Change in code * `verdepcheck.yml` action (see comments) - [x] Remove `on: push` section - [x] Change branch to main #### PRS - [x] verdepcheck * insightsengineering/verdepcheck#24 * insightsengineering/verdepcheck#26 - [x] verdepcheck-action * insightsengineering/r-verdepcheck-action#16 ### Changes description * Adds minimum version for packages `DESCRIPTION` * Adds `Config/Need/verdepcheck` section in `DESCRIPTION` * Updates verdepcheck action
averissimo
added a commit
to insightsengineering/dunlin
that referenced
this pull request
Sep 12, 2023
WIP :: parent issue: insightsengineering/nestdevs-tasks#7 Supersede: - #96 ### 🔴 Checklist for PR Reviewer ### 🔴 Checklist for PR Reviewer - [x] Tag yourself next to this repo on insightsengineering/nestdevs-tasks#7 - [x] Package versions are the same or higher than `main` - [x] Package list is the same - Only exception is `rmarkdown` (may have been removed on `Suggests`) - [x] All packages in `Imports`, `Depends` & `Suggests` are in new section `Config/Needs/verdepcheck` - [x] Added entry to `NEWS.md` - [x] Last `scheduled.yaml` action was run succesfully _(all 4 strategies)_ - important: it's not the last commit, it's the one that runs 4 `Scheduled 🕰️ / Dependency` actions - [x] `scheduled.yaml` SHOULD NOT have any push on any branches ### 🔴 What's needed before merging? This PR depends on some upstream changes that need to be finalized/merged before being ready to review. #### Change in code * `verdepcheck.yml` action (see comments) - [x] Remove `on: push` section - [x] Change branch to main #### PRS - [x] verdepcheck * insightsengineering/verdepcheck#24 * insightsengineering/verdepcheck#26 - [x] verdepcheck-action * insightsengineering/r-verdepcheck-action#16 ### Changes description * Adds minimum version for packages `DESCRIPTION` * Adds `Config/Need/verdepcheck` section in `DESCRIPTION` * Updates verdepcheck action
averissimo
added a commit
to insightsengineering/formatters
that referenced
this pull request
Sep 13, 2023
WIP :: parent issue: insightsengineering/nestdevs-tasks#7 Supersede: * #163 ### 🔴 Checklist for PR Reviewer - [ ] Tag yourself next to this repo on insightsengineering/nestdevs-tasks#7 - [ ] Package versions are the same or higher than `main` - [ ] Package list is the same - Only exception is `rmarkdown` (may have been removed on `Suggests`) - [ ] All packages in `Imports`, `Depends` & `Suggests` are in new section `Config/Needs/verdepcheck` - [ ] Added entry to `NEWS.md` - [ ] Last `scheduled.yaml` action was run succesfully _(all 4 strategies)_ - important: it's not the last commit, it's the one that runs 4 `Scheduled 🕰️ / Dependency` actions - [ ] `scheduled.yaml` SHOULD NOT have any push on any branches ### 🔴 What's needed before merging? This PR depends on some upstream changes that need to be finalized/merged before being ready to review. #### Change in code * `verdepcheck.yml` action (see comments) - [x] Remove `on: push` section - [x] Change branch to main #### PRS - [x] verdepcheck * insightsengineering/verdepcheck#24 * insightsengineering/verdepcheck#26 - [x] verdepcheck-action * insightsengineering/r-verdepcheck-action#16 ### Changes description * Adds minimum version for packages `DESCRIPTION` * Adds `Config/Need/verdepcheck` section in `DESCRIPTION` * Updates verdepcheck action
averissimo
added a commit
to insightsengineering/nestcolor
that referenced
this pull request
Sep 13, 2023
WIP :: parent issue: insightsengineering/nestdevs-tasks#7 Supersede: - #54 ### 🔴 Checklist for PR Reviewer - [ ] Tag yourself next to this repo on insightsengineering/nestdevs-tasks#7 - [x] Package versions are the same or higher than `main` - [x] Package list is the same - Only exception is `rmarkdown` (on `Suggests`) - [x] All packages in `Imports`, `Depends` & `Suggests` are in new section `Config/Needs/verdepcheck` - [x] Added entry to `NEWS.md` - [x] Last `scheduled.yaml` action was run succesfully _(all 4 strategies)_ - important: it's not the last commit, it's the one that runs 4 `Scheduled 🕰️ / Dependency` actions - [x] `scheduled.yaml` SHOULD NOT have any push on any branches ### 🔴 What's needed before merging? This PR depends on some upstream changes that need to be finalized/merged before being ready to review. #### Change in code * `verdepcheck.yml` action (see comments) - [x] Remove `on: push` section - [x] Change branch to main #### PRS - [x] verdepcheck * insightsengineering/verdepcheck#24 * insightsengineering/verdepcheck#26 - [x] verdepcheck-action * insightsengineering/r-verdepcheck-action#16 ### Changes description * Adds minimum version for packages `DESCRIPTION` * Adds `Config/Need/verdepcheck` section in `DESCRIPTION` * Updates verdepcheck action
averissimo
added a commit
to insightsengineering/teal.modules.general
that referenced
this pull request
Sep 14, 2023
WIP :: parent issue: insightsengineering/nestdevs-tasks#7 Supersede: * #527 ### 🔴 Checklist for PR Reviewer - [ ] Tag yourself next to this repo on insightsengineering/nestdevs-tasks#7 - [x] Package versions are the same or higher than `main` - [x] Package list is the same - Only exception is `rmarkdown` (may have been removed on `Suggests`) - [x] All packages in `Imports`, `Depends` & `Suggests` are in new section `Config/Needs/verdepcheck` - [x] Added entry to `NEWS.md` - [x] Last `scheduled.yaml` action was run succesfully _(all 4 strategies)_ - important: it's not the last commit, it's the one that runs 4 `Scheduled 🕰️ / Dependency` actions - [x] `scheduled.yaml` SHOULD NOT have any push on any branches ### 🔴 What's needed before merging? This PR depends on some upstream changes that need to be finalized/merged before being ready to review. #### Change in code * `verdepcheck.yml` action (see comments) - [x] Remove `on: push` section - [x] Change branch to main #### PRS - [x] verdepcheck * insightsengineering/verdepcheck#24 * insightsengineering/verdepcheck#26 - [x] verdepcheck-action * insightsengineering/r-verdepcheck-action#16 ### Changes description * Adds minimum version for packages `DESCRIPTION` * Adds `Config/Need/verdepcheck` section in `DESCRIPTION` * Updates verdepcheck action
averissimo
added a commit
to insightsengineering/random.cdisc.data
that referenced
this pull request
Sep 15, 2023
WIP :: parent issue: insightsengineering/nestdevs-tasks#7 Supersede: - #278 ### 🔴 Checklist for PR Reviewer - [ ] Tag yourself next to this repo on insightsengineering/nestdevs-tasks#7 - [x] Package versions are the same or higher than `main` - [x] Package list is the same - Only exception is `rmarkdown` (may have been removed on `Suggests`) - [x] All packages in `Imports`, `Depends` & `Suggests` are in new section `Config/Needs/verdepcheck` - [x] Added entry to `NEWS.md` - [x] Last `scheduled.yaml` action was run succesfully _(all 4 strategies)_ - important: it's not the last commit, it's the one that runs 4 `Scheduled 🕰️ / Dependency` actions - [x] `scheduled.yaml` SHOULD NOT have any push on any branches ### 🔴 What's needed before merging? This PR depends on some upstream changes that need to be finalized/merged before being ready to review. #### Change in code * `verdepcheck.yml` action (see comments) - [x] Remove `on: push` section - [x] Change branch to main #### PRS - [x] verdepcheck * insightsengineering/verdepcheck#24 * insightsengineering/verdepcheck#26 - [x] verdepcheck-action * insightsengineering/r-verdepcheck-action#16 ### Changes description * Adds minimum version for packages `DESCRIPTION` * Adds `Config/Need/verdepcheck` section in `DESCRIPTION` * Updates verdepcheck action --------- Signed-off-by: Marcin <[email protected]> Co-authored-by: Marcin <[email protected]>
averissimo
added a commit
to insightsengineering/rlistings
that referenced
this pull request
Sep 15, 2023
WIP :: parent issue: insightsengineering/nestdevs-tasks#7 Supersede: * #130 ### 🔴 Checklist for PR Reviewer - [ ] Tag yourself next to this repo on insightsengineering/nestdevs-tasks#7 - [ ] Package versions are the same or higher than `main` - [ ] Package list is the same - Only exception is `rmarkdown` (may have been removed on `Suggests`) - [ ] All packages in `Imports`, `Depends` & `Suggests` are in new section `Config/Needs/verdepcheck` - [ ] Added entry to `NEWS.md` - [ ] Last `scheduled.yaml` action was run succesfully _(all 4 strategies)_ - important: it's not the last commit, it's the one that runs 4 `Scheduled 🕰️ / Dependency` actions - [ ] `scheduled.yaml` SHOULD NOT have any push on any branches ### 🔴 What's needed before merging? This PR depends on some upstream changes that need to be finalized/merged before being ready to review. #### Change in code * [x] `formatters` release of the next version and update DESCRIPTION accordingly * `fmt_config` is required and only available at `formatters@main` atm * `verdepcheck.yml` action (see comments) - [x] Remove `on: push` section - [x] Change branch to main #### PRS - [x] verdepcheck * insightsengineering/verdepcheck#24 * insightsengineering/verdepcheck#26 - [x] verdepcheck-action * insightsengineering/r-verdepcheck-action#16 ### Changes description * Adds minimum version for packages `DESCRIPTION` * Adds `Config/Need/verdepcheck` section in `DESCRIPTION` * Updates verdepcheck action --------- Co-authored-by: Marcin <[email protected]>
averissimo
added a commit
to insightsengineering/teal.slice
that referenced
this pull request
Sep 21, 2023
WIP :: parent issue: insightsengineering/nestdevs-tasks#7 Supersede: * #332 ### 🔴 Checklist for PR Reviewer [](https://github.com/insightsengineering/teal.slice/actions/workflows/scheduled.yaml?query=branch%3Averdepcheck_action) _(see comment below)_ - [ ] Tag yourself next to this repo on insightsengineering/nestdevs-tasks#7 - [ ] Package versions are the same or higher than `main` - [x] Package list is the same - Only exception is `rmarkdown` (may have been removed on `Suggests`) - [x] All packages in `Imports`, `Depends` & `Suggests` are in new section `Config/Needs/verdepcheck` - [x] Added entry to `NEWS.md` - [ ] Last `scheduled.yaml` action was run succesfully _(all 4 strategies)_ - important: it's not the last commit, it's the one that runs 4 `Scheduled 🕰️ / Dependency` actions - [x] `scheduled.yaml` SHOULD NOT have any push on any branches ### 🔴 What's needed before merging? This PR depends on some upstream changes that need to be finalized/merged before being ready to review. #### Change in code * `verdepcheck.yml` action (see comments) - [x] Remove `on: push` section - [x] Change branch to main #### PRS - [x] verdepcheck * insightsengineering/verdepcheck#24 * insightsengineering/verdepcheck#26 - [x] verdepcheck-action * insightsengineering/r-verdepcheck-action#16 ### Changes description * Adds minimum version for packages `DESCRIPTION` * Adds `Config/Need/verdepcheck` section in `DESCRIPTION` * Updates verdepcheck action
](https://github.com/insightsengineering/teal.slice/actions/workflows/scheduled.yaml?query=branch%3Averdepcheck_action){kind=link}
averissimo
added a commit
to insightsengineering/teal.logger
that referenced
this pull request
Oct 16, 2023
WIP :: parent issue: insightsengineering/nestdevs-tasks#7 Supersede: * #45 ### 🔴 Checklist for PR Reviewer [](https://github.com/insightsengineering/teal.logger/actions/workflows/scheduled.yaml?query=branch%3Averdepcheck_action) _(see comment below)_ - [x] Tag yourself next to this repo on insightsengineering/nestdevs-tasks#7 - [x] Package versions are the same or higher than `main` - [x] Package list is the same - Only exception is `rmarkdown` (may have been removed on `Suggests`) - [x] All packages in `Imports`, `Depends` & `Suggests` are in new section `Config/Needs/verdepcheck` - [x] Added entry to `NEWS.md` - [x] Last `scheduled.yaml` action was run succesfully _(all 4 strategies)_ - important: it's not the last commit, it's the one that runs 4 `Scheduled 🕰️ / Dependency` actions - [x] `scheduled.yaml` SHOULD NOT have any push on any branches ### 🔴 What's needed before merging? This PR depends on some upstream changes that need to be finalized/merged before being ready to review. #### Change in code * `verdepcheck.yml` action (see comments) - [x] Remove `on: push` section - [x] Change branch to main #### PRS - [x] verdepcheck * insightsengineering/verdepcheck#24 * insightsengineering/verdepcheck#26 - [x] verdepcheck-action * insightsengineering/r-verdepcheck-action#16 ### Changes description * Adds minimum version for packages `DESCRIPTION` * Adds `Config/Need/verdepcheck` section in `DESCRIPTION` * Updates verdepcheck action --------- Signed-off-by: Marcin <[email protected]> Co-authored-by: Marcin <[email protected]>
](https://github.com/insightsengineering/teal.logger/actions/workflows/scheduled.yaml?query=branch%3Averdepcheck_action){kind=link}
averissimo
added a commit
to insightsengineering/tern.rbmi
that referenced
this pull request
Oct 19, 2023
WIP :: parent issue: insightsengineering/nestdevs-tasks#7 ### 🔴 Checklist for PR Reviewer [](https://github.com/insightsengineering/tern.rbmi/actions/workflows/scheduled.yaml?query=branch%3Averdepcheck_action) - [x] Tag yourself next to this repo on insightsengineering/nestdevs-tasks#7 - [x] Package versions are the same or higher than `main` - [x] Package list is the same - Only exception is `rmarkdown` (may have been removed on `Suggests`) - [x] All packages in `Imports`, `Depends` & `Suggests` are in new section `Config/Needs/verdepcheck` - [x] Added entry to `NEWS.md` - [x] Last `scheduled.yaml` action was run succesfully _(all 4 strategies)_ - important: it's not the last commit, it's the one that runs 4 `Scheduled 🕰️ / Dependency` actions - [x] `scheduled.yaml` SHOULD NOT have any push on any branches ### 🔴 What's needed before merging? This PR depends on some upstream changes that need to be finalized/merged before being ready to review. #### Change in code * `verdepcheck.yml` action (see comments) - [x] Remove `on: push` section - [x] Change branch to main #### PRS - [x] verdepcheck * insightsengineering/verdepcheck#24 * insightsengineering/verdepcheck#26 - [x] verdepcheck-action * insightsengineering/r-verdepcheck-action#16 ### Changes description * Adds minimum version for packages `DESCRIPTION` * Adds `Config/Need/verdepcheck` section in `DESCRIPTION` * Updates verdepcheck action
](https://github.com/insightsengineering/tern.rbmi/actions/workflows/scheduled.yaml?query=branch%3Averdepcheck_action){kind=link}
shajoezhu
pushed a commit
to insightsengineering/tern
that referenced
this pull request
Oct 23, 2023
WIP :: parent issue: insightsengineering/nestdevs-tasks#7 Supersede: * #957 ### 🔴 Checklist for PR Reviewer [](https://github.com/insightsengineering/tern/actions/workflows/scheduled.yaml) _(~~max strategy fails due to tidyverse/ggplot2#5436 corrected upstream)_ - [ ] Tag yourself next to this repo on insightsengineering/nestdevs-tasks#7 - [ ] Package versions are the same or higher than `main` - [ ] Package list is the same - Only exception is `rmarkdown` (may have been removed on `Suggests`) - [ ] All packages in `Imports`, `Depends` & `Suggests` are in new section `Config/Needs/verdepcheck` - [ ] Added entry to `NEWS.md` - [ ] Last `scheduled.yaml` action was run succesfully _(all 4 strategies)_ - important: it's not the last commit, it's the one that runs 4 `Scheduled 🕰️ / Dependency` actions - [ ] `scheduled.yaml` SHOULD NOT have any push on any branches ### 🔴 What's needed before merging? This PR depends on some upstream changes that need to be finalized/merged before being ready to review. #### Change in code * `verdepcheck.yml` action (see comments) - [x] Remove `on: push` section - [x] Change branch to main #### PRS - [x] verdepcheck * insightsengineering/verdepcheck#24 * insightsengineering/verdepcheck#26 - [x] verdepcheck-action * insightsengineering/r-verdepcheck-action#16 ### Changes description * Adds minimum version for packages `DESCRIPTION` * Adds `Config/Need/verdepcheck` section in `DESCRIPTION` * Updates verdepcheck action --------- Signed-off-by: André Veríssimo <[email protected]> Co-authored-by: Pawel Rucki <[email protected]>
](https://github.com/insightsengineering/tern/actions/workflows/scheduled.yaml){kind=link}
walkowif
pushed a commit
to walkowif/teal
that referenced
this pull request
Dec 5, 2023
WIP :: parent issue: insightsengineering/nestdevs-tasks#7 ### 🔴 Checklist for PR Reviewer [](https://github.com/insightsengineering/teal/actions/workflows/scheduled.yaml?query=branch%3Averdepcheck_action) _(`max` and `release` strategies are expected to fail... see below)_ - [ ] Tag yourself next to this repo on insightsengineering/nestdevs-tasks#7 - [ ] Package versions are the same or higher than `main` - [ ] Package list is the same - Only exception is `rmarkdown` (may have been removed on `Suggests`) - [ ] All packages in `Imports`, `Depends` & `Suggests` are in new section `Config/Needs/verdepcheck` - [ ] Added entry to `NEWS.md` - [ ] Last `scheduled.yaml` action was run succesfully _(all 4 strategies)_ - important: it's not the last commit, it's the one that runs 4 `Scheduled 🕰️ / Dependency` actions - [ ] `scheduled.yaml` SHOULD NOT have any push on any branches ### 🔴 What's needed before merging? This PR depends on some upstream changes that need to be finalized/merged before being ready to review. #### Change in code * `verdepcheck.yml` action (see comments) - [x] Remove `on: push` section - [x] Change branch to main #### PRS - [x] verdepcheck * insightsengineering/verdepcheck#24 * insightsengineering/verdepcheck#26 - [x] verdepcheck-action * insightsengineering/r-verdepcheck-action#16 ### Changes description * Adds minimum version for packages `DESCRIPTION` * Adds `Config/Need/verdepcheck` section in `DESCRIPTION` * Updates verdepcheck action
](https://github.com/insightsengineering/teal/actions/workflows/scheduled.yaml?query=branch%3Averdepcheck_action){kind=link}
clarkliming
pushed a commit
to insightsengineering/chevron
that referenced
this pull request
Dec 18, 2023
WIP :: parent issue: insightsengineering/nestdevs-tasks#7 Supersede: - #517 ### 🔴 Checklist for PR Reviewer - [ ] Tag yourself next to this repo on insightsengineering/nestdevs-tasks#7 - [ ] Package versions are the same or higher than `main` - [ ] Package list is the same - [ ] All packages in `Imports`, `Depends` & `Suggests` are in new section `Config/Needs/verdepcheck` - [ ] Added entry to `NEWS.md` - [ ] Last `scheduled.yaml` action was run succesfully _(all 4 strategies)_ - important: it's not the last commit, it's the one that runs 4 `Scheduled 🕰️ / Dependency` actions - [ ] `scheduled.yaml` SHOULD NOT have any push on any branches ### 🔴 What's needed before merging? This PR depends on some upstream changes that need to be finalized/merged before being ready to review. #### Change in code * `verdepcheck.yml` action (see comments) - [x] Remove `on: push` section - [x] Change branch to main #### PRS - [ ] verdepcheck * insightsengineering/verdepcheck#24 * insightsengineering/verdepcheck#26 - [ ] verdepcheck-action * insightsengineering/r-verdepcheck-action#16 ### Changes description * Adds minimum version for packages `DESCRIPTION` * Adds `Config/Need/verdepcheck` section in `DESCRIPTION` * Updates verdepcheck action
averissimo
added a commit
to insightsengineering/teal.modules.clinical
that referenced
this pull request
Jan 29, 2024
WIP :: parent issue: insightsengineering/nestdevs-tasks#7 Supersede: * #780 ### 🔴 What's needed before merging? This PR depends on some upstream changes that need to be finalized/merged before being ready to review. #### Change in code * `verdepcheck.yml` action (see comments) - [ ] Remove `on: push` section - [x] Change branch to main #### PRS - [x] verdepcheck * insightsengineering/verdepcheck#24 * insightsengineering/verdepcheck#26 - [x] verdepcheck-action * insightsengineering/r-verdepcheck-action#16 ### Changes description * Adds minimum version for packages `DESCRIPTION` * Adds `Config/Need/verdepcheck` section in `DESCRIPTION` * Updates verdepcheck action --------- Signed-off-by: André Veríssimo <[email protected]> Co-authored-by: Pawel Rucki <[email protected]>
pawelru
added a commit
to insightsengineering/teal.osprey
that referenced
this pull request
Apr 8, 2024
WIP :: parent issue: insightsengineering/nestdevs-tasks#7 Supersede: * #206 ### 🔴 What's needed before merging? This PR depends on some upstream changes that need to be finalized/merged before being ready to review. #### Change in code * `verdepcheck.yml` action (see comments) - [ ] Remove `on: push` section - [x] Change branch to main #### PRS - [x] verdepcheck * insightsengineering/verdepcheck#24 * insightsengineering/verdepcheck#26 - [x] verdepcheck-action * insightsengineering/r-verdepcheck-action#16 ### Changes description * Adds minimum version for packages `DESCRIPTION` * Adds `Config/Need/verdepcheck` section in `DESCRIPTION` * Updates verdepcheck action --------- Signed-off-by: Pawel Rucki <[email protected]> Co-authored-by: Pawel Rucki <[email protected]>
pawelru
added a commit
to insightsengineering/teal.goshawk
that referenced
this pull request
Apr 9, 2024
WIP :: parent issue: insightsengineering/nestdevs-tasks#7 Supersede: * #218 ### 🔴 What's needed before merging? This PR depends on some upstream changes that need to be finalized/merged before being ready to review. #### Change in code * `verdepcheck.yml` action (see comments) - [x] Remove `on: push` section - [x] Change branch to main #### PRS - [x] verdepcheck * insightsengineering/verdepcheck#24 * insightsengineering/verdepcheck#26 - [x] verdepcheck-action * insightsengineering/r-verdepcheck-action#16 ### Changes description * Adds minimum version for packages `DESCRIPTION` * Adds `Config/Need/verdepcheck` section in `DESCRIPTION` * Updates verdepcheck action --------- Signed-off-by: Pawel Rucki <[email protected]> Co-authored-by: Pawel Rucki <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP :: parent issue: insightsengineering/nestdevs-tasks#7
🔴 What's needed before merging?
Changes in code
@training-improvementsto@mainPR
Changes description
minstrategy withmin_isolatedandmin_cohorts