Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MNG01 test snapshots #707

Merged
merged 1 commit into from
Dec 6, 2023
Merged

Update MNG01 test snapshots #707

merged 1 commit into from
Dec 6, 2023

Conversation

edelarua
Copy link
Contributor

@edelarua edelarua commented Dec 6, 2023

Corresponds to changes in tern: insightsengineering/tern#1153

Closes #706

Copy link
Contributor

github-actions bot commented Dec 6, 2023

badge

Code Coverage Summary

Filename                     Stmts    Miss  Cover    Missing
-------------------------  -------  ------  -------  ---------------------------------------------------------------------
R/ael01_nollt.R                 21       1  95.24%   72
R/aet01_aesi.R                 148       1  99.32%   211
R/aet01.R                       98       1  98.98%   168
R/aet02.R                       44       0  100.00%
R/aet03.R                       76       0  100.00%
R/aet04.R                       88       0  100.00%
R/aet05_all.R                   11       0  100.00%
R/aet05.R                       44       1  97.73%   114
R/aet10.R                       42       0  100.00%
R/assertions.R                  80       6  92.50%   10-15
R/cfbt01.R                     107       0  100.00%
R/checks.R                      14       0  100.00%
R/chevron_tlg-S4class.R         24       0  100.00%
R/chevron_tlg-S4methods.R      144       1  99.31%   67
R/cmt01a.R                      52       0  100.00%
R/coxt01.R                      49       1  97.96%   129
R/dmt01.R                       36       0  100.00%
R/dst01.R                       94       0  100.00%
R/dtht01.R                     102       6  94.12%   50, 54-58
R/egt02.R                       35       0  100.00%
R/egt03.R                       80       1  98.75%   153
R/egt05_qtcat.R                 78       0  100.00%
R/ext01.R                       59       1  98.31%   50
R/fstg01.R                      44       0  100.00%
R/fstg02.R                      49       0  100.00%
R/kmg01.R                       29       0  100.00%
R/lbt04.R                       90       0  100.00%
R/lbt05.R                       66       5  92.42%   123-128
R/lbt06.R                       70       3  95.71%   141-144
R/lbt07.R                       93       0  100.00%
R/lbt14.R                       64       0  100.00%
R/lbt15.R                       20       0  100.00%
R/mht01.R                       54       0  100.00%
R/mng01.R                       82       9  89.02%   82, 86-90, 110-111, 153
R/pdt01.R                       60       0  100.00%
R/pdt02.R                       68       0  100.00%
R/rmpt01.R                      59      11  81.36%   87-96, 131
R/rmpt06.R                     134       3  97.76%   209-212
R/rspt01.R                      73       3  95.89%   155-158
R/rtables_utils.R              325      23  92.92%   51, 68, 119, 243, 264, 409-416, 483, 498-500, 502, 571-577, 587, 608
R/standard_rules.R              13       0  100.00%
R/ttet01.R                     125       3  97.60%   206-209
R/utils.R                      156      21  86.54%   141, 156, 175-177, 294-297, 301-304, 331, 335, 347, 349, 361, 378-380
R/vst02.R                       45       1  97.78%   108
TOTAL                         3245     102  96.86%

Diff against main

Filename                     Stmts    Miss  Cover
-------------------------  -------  ------  --------
R/aet01_aesi.R                  -2       0  -0.01%
R/aet01.R                       +4       0  +0.04%
R/aet02.R                       -6       0  +100.00%
R/aet03.R                       -1       0  +100.00%
R/aet04.R                       -1       0  +100.00%
R/aet05.R                       +4       0  +0.23%
R/aet10.R                       -1       0  +100.00%
R/assertions.R                 -19       0  -1.44%
R/chevron_tlg-S4class.R         +6       0  +100.00%
R/chevron_tlg-S4methods.R       +8      -3  +2.25%
R/cmt01a.R                      -6      -6  +10.34%
R/coxt01.R                      +1       0  +0.04%
R/dmt01.R                       +7       0  +100.00%
R/dst01.R                       -1       0  +100.00%
R/dtht01.R                      -1       0  -0.06%
R/egt02.R                       -2       0  +100.00%
R/egt03.R                       +3       0  +0.05%
R/egt05_qtcat.R                 -1       0  +100.00%
R/ext01.R                       -1       0  -0.03%
R/fstg01.R                      -6       0  +100.00%
R/fstg02.R                      -6       0  +100.00%
R/lbt04.R                       -1       0  +100.00%
R/lbt05.R                       -1       0  -0.11%
R/lbt06.R                       -2       0  -0.12%
R/lbt07.R                       -1       0  +100.00%
R/lbt14.R                       -2       0  +100.00%
R/mht01.R                      -17       0  +100.00%
R/mng01.R                      -14      +8  -9.93%
R/pdt02.R                       -1       0  +100.00%
R/rmpt01.R                      -6       0  -1.72%
R/rmpt06.R                    +134      +3  +97.76%
R/rtables_utils.R              +25      +4  -0.74%
R/standard_rules.R              +2       0  +100.00%
R/ttet01.R                      +8       0  +0.16%
R/utils.R                      +72     +21  -13.46%
R/vst02.R                       -1       0  -0.05%
TOTAL                         +174     +27  -0.70%

Results for commit: 42474cd

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented Dec 6, 2023

Unit Tests Summary

    1 files    53 suites   3m 13s ⏱️
237 tests 169 ✔️   68 💤 0
461 runs  297 ✔️ 164 💤 0

Results for commit 42474cd.

Copy link
Contributor

github-actions bot commented Dec 6, 2023

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
cfbt01 💚 $11.66$ $-1.95$ $0$ $0$ $0$ $0$
chevron_tlg-methods 💚 $10.50$ $-1.90$ $0$ $0$ $0$ $0$
default_tlg 💚 $14.24$ $-2.42$ $0$ $0$ $0$ $0$
egt01 💚 $8.48$ $-1.57$ $0$ $0$ $0$ $0$
fstg01 💚 $8.00$ $-1.47$ $0$ $0$ $0$ $0$
fstg02 💚 $10.50$ $-2.11$ $0$ $0$ $0$ $0$
lbt01 💚 $11.82$ $-2.00$ $0$ $0$ $0$ $0$
lbt14 💚 $35.80$ $-6.38$ $0$ $0$ $0$ $0$
lbt15 💚 $7.08$ $-1.39$ $0$ $0$ $0$ $0$
mng01 💚 $8.46$ $-1.51$ $0$ $0$ $0$ $0$
vst01 💚 $17.49$ $-3.00$ $0$ $0$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
cfbt01 💚 $8.65$ $-1.43$ cfbt01_functions_with_default_argument_value_return_expected_result_with_test_data
lbt14 💚 $6.33$ $-1.18$ lbt14_can_accept_different_gr_missing
lbt14 💚 $6.20$ $-1.19$ lbt14_can_accept_different_gr_missing_with_direction_high
vst01 💚 $8.94$ $-1.73$ run_vst01_works_as_expected
vst01 💚 $8.55$ $-1.27$ vst01_functions_with_default_argument_value_return_expected_result_with_test_data

Results for commit 8b6a339

♻️ This comment has been updated with latest results.

@edelarua edelarua enabled auto-merge (squash) December 6, 2023 17:30
Copy link
Contributor

@clarkliming clarkliming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you, looks good

@edelarua edelarua merged commit 634332b into main Dec 6, 2023
21 checks passed
@edelarua edelarua deleted the 706_fix_lineplot_snaps@main branch December 6, 2023 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix lineplot test snapshots
2 participants