-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vertically align plot with table in g_lineplot
#1153
Conversation
Code Coverage Summary
Diff against main
Results for commit: 2fb36df Minimum allowed coverage is ♻️ This comment has been updated with latest results |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @edelarua
follow-up on #1153 Integration test warns for chevron: ``` ── Warning ('test-mng01.R:18:3'): mng01 works as expected with custom argument values ── Graphs cannot be vertically aligned unless the axis parameter is set. Placing graphs unaligned. Backtrace: ▆ 1. └─chevron::mng01_main(...) at test-mng01.R:18:3 2. └─base::lapply(...) 3. └─tern (local) FUN(X[[i]], ...) 4. └─cowplot::plot_grid(p, tbl, ncol = 1, align = "v") 5. └─cowplot::align_plots(...) ``` It might happen that snapshot test will fail. In such case please kindly provide some help. I have re-run snapshots locally and I got differences for unrelated graphs like KM Plots. This has to do with my local settings. I might be unable to get same graphs like in CI.
Hi @edelarua , I was wondering if we need to update tmc downstream, or if this happens automatically |
@shajoezhu it will update automatically in tmc - no action needed! |
Brilliant! Thanks Em |
Pull Request
Fixes #1152