Skip to content

Commit

Permalink
Adds min package version (#182)
Browse files Browse the repository at this point in the history
WIP :: parent issue:
insightsengineering/nestdevs-tasks#7

Supersede:
* #163

### 🔴 Checklist for PR Reviewer

- [ ] Tag yourself next to this repo on
insightsengineering/nestdevs-tasks#7
- [ ] Package versions are the same or higher than `main`
- [ ] Package list is the same
  - Only exception is `rmarkdown` (may have been removed on `Suggests`)
- [ ] All packages in `Imports`, `Depends` & `Suggests` are in new
section `Config/Needs/verdepcheck`
- [ ] Added entry to `NEWS.md`
- [ ] Last `scheduled.yaml` action was run succesfully _(all 4
strategies)_
- important: it's not the last commit, it's the one that runs 4
`Scheduled 🕰️ / Dependency` actions
- [ ] `scheduled.yaml` SHOULD NOT have any push on any branches

### 🔴 What's needed before merging?

This PR depends on some upstream changes that need to be
finalized/merged before being ready to review.

#### Change in code

* `verdepcheck.yml` action (see comments)
  - [x] Remove `on: push` section 
  - [x] Change branch to main

#### PRS

- [x] verdepcheck
  * insightsengineering/verdepcheck#24
  * insightsengineering/verdepcheck#26
- [x] verdepcheck-action
  * insightsengineering/r-verdepcheck-action#16

### Changes description

* Adds minimum version for packages `DESCRIPTION`
* Adds `Config/Need/verdepcheck` section in `DESCRIPTION`
* Updates verdepcheck action
  • Loading branch information
averissimo authored Sep 13, 2023
1 parent 236d62b commit 76eac91
Show file tree
Hide file tree
Showing 3 changed files with 22 additions and 13 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/scheduled.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
strategy:
fail-fast: false
matrix:
test-strategy: ["min", "release", "max"]
test-strategy: ["min_cohort", "min_isolated", "release", "max"]
uses: insightsengineering/r.pkg.template/.github/workflows/verdepcheck.yaml@main
name: Dependency Test - ${{ matrix.test-strategy }} 🔢
secrets:
Expand Down
32 changes: 20 additions & 12 deletions DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -18,30 +18,38 @@ Description: We provide a framework for rendering complex tables to ASCII,
License: Apache License 2.0
URL: https://github.com/insightsengineering/formatters
BugReports: https://github.com/insightsengineering/formatters/issues
Depends:
Depends:
methods,
R (>= 2.10)
Imports:
checkmate,
Imports:
checkmate (>= 2.1.0),
grid,
htmltools
htmltools (>= 0.5.3)
Suggests:
dplyr,
dplyr (>= 1.0.9),
gt (>= 0.7.0),
huxtable,
knitr,
r2rtf,
rmarkdown,
testthat
VignetteBuilder:
huxtable (>= 2.0.0),
knitr (>= 1.42),
r2rtf (>= 0.3.2),
testthat (>= 3.0.4)
VignetteBuilder:
knitr
Config/Needs/verdepcheck:
mllg/checkmate,
rstudio/htmltools,
tidyverse/dplyr,
rstudio/gt,
hughjonesd/huxtable,
yihui/knitr,
Merck/r2rtf,
r-lib/testthat
Config/Needs/website: insightsengineering/nesttemplate
Encoding: UTF-8
Language: en-US
LazyData: true
Roxygen: list(markdown = TRUE)
RoxygenNote: 7.2.3
Collate:
Collate:
'data.R'
'format_value.R'
'matrix_form.R'
Expand Down
1 change: 1 addition & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
## formatters 0.5.2.9001
* Specified minimal version of package dependencies.

## formatters 0.5.2
* `paginate_to_mpfs` can handle single column tables and listings.
Expand Down

0 comments on commit 76eac91

Please sign in to comment.