Skip to content

Commit

Permalink
Adds min package version (#286)
Browse files Browse the repository at this point in the history
WIP :: parent issue:
insightsengineering/nestdevs-tasks#7

Supersede:
- #278 

### 🔴 Checklist for PR Reviewer

- [ ] Tag yourself next to this repo on
insightsengineering/nestdevs-tasks#7
- [x] Package versions are the same or higher than `main`
- [x] Package list is the same
  - Only exception is `rmarkdown` (may have been removed on `Suggests`)
- [x] All packages in `Imports`, `Depends` & `Suggests` are in new
section `Config/Needs/verdepcheck`
- [x] Added entry to `NEWS.md`
- [x] Last `scheduled.yaml` action was run succesfully _(all 4
strategies)_
- important: it's not the last commit, it's the one that runs 4
`Scheduled 🕰️ / Dependency` actions
- [x] `scheduled.yaml` SHOULD NOT have any push on any branches

### 🔴 What's needed before merging?

This PR depends on some upstream changes that need to be
finalized/merged before being ready to review.

#### Change in code

* `verdepcheck.yml` action (see comments)
  - [x] Remove `on: push` section 
  - [x] Change branch to main

#### PRS

- [x] verdepcheck
  * insightsengineering/verdepcheck#24
  * insightsengineering/verdepcheck#26
- [x] verdepcheck-action
  * insightsengineering/r-verdepcheck-action#16

### Changes description

* Adds minimum version for packages `DESCRIPTION`
* Adds `Config/Need/verdepcheck` section in `DESCRIPTION`
* Updates verdepcheck action

---------

Signed-off-by: Marcin <[email protected]>
Co-authored-by: Marcin <[email protected]>
  • Loading branch information
averissimo and m7pr authored Sep 15, 2023
1 parent e64b270 commit 22134ab
Show file tree
Hide file tree
Showing 3 changed files with 31 additions and 13 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/scheduled.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
strategy:
fail-fast: false
matrix:
test-strategy: ["min", "release", "max"]
test-strategy: ["min_cohort", "min_isolated", "release", "max"]
uses: insightsengineering/r.pkg.template/.github/workflows/verdepcheck.yaml@main
name: Dependency Test - ${{ matrix.test-strategy }} 🔢
secrets:
Expand Down
39 changes: 27 additions & 12 deletions DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -17,26 +17,41 @@ License: Apache License 2.0 | file LICENSE
Depends:
R (>= 3.6)
Imports:
checkmate,
checkmate (>= 2.1.0),
dplyr (>= 1.1.2),
lifecycle,
lubridate,
magrittr,
rlang,
stringr,
tibble,
tidyr,
yaml
lifecycle (>= 1.0.3),
lubridate (>= 1.7.10),
magrittr (>= 1.5),
rlang (>= 1.1.0),
stringr (>= 1.4.1),
tibble (>= 3.2.1),
tidyr (>= 1.1.4),
yaml (>= 2.1.19)
Suggests:
diffdf,
knitr,
rmarkdown,
testthat (>= 3.0)
knitr (>= 1.42),
rmarkdown (>= 2.19),
testthat (>= 3.0.4)
VignetteBuilder:
knitr
RdMacros:
lifecycle
Config/Needs/website: insightsengineering/nesttemplate
Config/Needs/verdepcheck:
mllg/checkmate,
tidyverse/dplyr,
r-lib/lifecycle,
tidyverse/lubridate,
tidyverse/magrittr,
r-lib/rlang,
tidyverse/stringr,
tidyverse/tibble,
tidyverse/tidyr,
yaml=vubiostat/r-yaml,
gowerc/diffdf,
yihui/knitr,
rstudio/rmarkdown,
r-lib/testthat
Config/testthat/edition: 3
Encoding: UTF-8
Language: en-US
Expand Down
3 changes: 3 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@
### Enhancements
* Updated level of `ETHNIC` variable in all datasets from `" NOT REPORTED"` to `"NOT REPORTED"`.

### Miscellaneous
* Specified minimal version of package dependencies.

# random.cdisc.data 0.3.14

### Breaking changes
Expand Down

0 comments on commit 22134ab

Please sign in to comment.