Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

verdepcheck #45

Closed
wants to merge 1 commit into from
Closed

verdepcheck #45

wants to merge 1 commit into from

Conversation

pawelru
Copy link
Contributor

@pawelru pawelru commented Jun 9, 2023

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 9, 2023

badge

Code Coverage Summary

Filename               Stmts    Miss  Cover    Missing
-------------------  -------  ------  -------  ---------
R/register_logger.R       56       1  98.21%   112
R/supress_logs.R           5       5  0.00%    17-21
R/utils.R                 17       0  100.00%
R/zzz.R                    2       2  0.00%    3-4
TOTAL                     80       8  90.00%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 3c1f605

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions
Copy link
Contributor

github-actions bot commented Jun 9, 2023

Unit Tests Summary

10 tests   10 ✔️  0s ⏱️
  1 suites    0 💤
  1 files      0

Results for commit d865f11.

@averissimo averissimo mentioned this pull request Jul 26, 2023
11 tasks
@pawelru pawelru closed this Aug 18, 2023
@pawelru pawelru deleted the min_deps branch August 18, 2023 09:23
averissimo added a commit that referenced this pull request Oct 16, 2023
WIP :: parent issue:
insightsengineering/nestdevs-tasks#7

Supersede:
* #45

### 🔴 Checklist for PR Reviewer

[![Scheduled
🕰️](https://github.com/insightsengineering/teal.logger/actions/workflows/scheduled.yaml/badge.svg?branch=verdepcheck_action)](https://github.com/insightsengineering/teal.logger/actions/workflows/scheduled.yaml?query=branch%3Averdepcheck_action)
_(see comment below)_

- [x] Tag yourself next to this repo on
insightsengineering/nestdevs-tasks#7
- [x] Package versions are the same or higher than `main`
- [x] Package list is the same
  - Only exception is `rmarkdown` (may have been removed on `Suggests`)
- [x] All packages in `Imports`, `Depends` & `Suggests` are in new
section `Config/Needs/verdepcheck`
- [x] Added entry to `NEWS.md`
- [x] Last `scheduled.yaml` action was run succesfully _(all 4
strategies)_
- important: it's not the last commit, it's the one that runs 4
`Scheduled 🕰️ / Dependency` actions
- [x] `scheduled.yaml` SHOULD NOT have any push on any branches

### 🔴 What's needed before merging?

This PR depends on some upstream changes that need to be
finalized/merged before being ready to review.

#### Change in code

* `verdepcheck.yml` action (see comments)
  - [x] Remove `on: push` section 
  - [x] Change branch to main

#### PRS

- [x] verdepcheck
  * insightsengineering/verdepcheck#24
  * insightsengineering/verdepcheck#26
- [x] verdepcheck-action
  * insightsengineering/r-verdepcheck-action#16

### Changes description

* Adds minimum version for packages `DESCRIPTION`
* Adds `Config/Need/verdepcheck` section in `DESCRIPTION`
* Updates verdepcheck action

---------

Signed-off-by: Marcin <[email protected]>
Co-authored-by: Marcin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant