Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce disable filters in FilterPanelApi/FilteredData #84

Closed
Tracked by #69
gogonzo opened this issue Aug 4, 2022 · 6 comments · Fixed by #123
Closed
Tracked by #69

Introduce disable filters in FilterPanelApi/FilteredData #84

gogonzo opened this issue Aug 4, 2022 · 6 comments · Fixed by #123
Assignees
Labels

Comments

@gogonzo
Copy link
Contributor

gogonzo commented Aug 4, 2022

Please add option to disable filters for particular module. This particular module should get unfiltered data when toggle filter through FilterPanelApi

@gogonzo gogonzo added the core label Aug 4, 2022
@gogonzo gogonzo changed the title Instrudice disable filters in FilterPanelApi/FilteredData Introduce disable filters in FilterPanelApi/FilteredData Aug 15, 2022
@nikolas-burkoff
Copy link
Contributor

Should this be module specific? Isn't it easier for both app developers and app users to have one global toggle which turns the filter panel on/off for all modules? i.e. here

@donyunardi
Copy link
Contributor

Hi @kumamiao, can you help us on this? Do you think user would prefer global on/off or module-level on/off?
Or maybe both?

@kumamiao
Copy link

I feel like should we consider putting a hold on this issue, as we're planning for a bigger design change for the filter panel (which could potentially involve the setup for global & module-specific filters)?

@gogonzo
Copy link
Contributor Author

gogonzo commented Aug 30, 2022

@kumamiao we prefer to go through as we are working on the feature branch (this won't land on main until we have a stable teal version). This will be easier for developers to move forward with having quosure implemented in all modules. Disable/enable filters can be reverted and modified at any point.

@kumamiao
Copy link

kumamiao commented Sep 1, 2022

In this case let's move forward with this issue. I would propose to go with what Nik suggested, have one global toggle which turns the filter panel on/off for all modules - although one concern here, if switched from on->off->on, would the default choices come back to previous selected filters, or everything would be wiped off? The former would be preferred if possible.

In the future if we want to enable and then implement module-level toggle, then that toggle would be only applicable for module-specific filters and not impact global filters.

@nikolas-burkoff
Copy link
Contributor

although one concern here, if switched from on->off->on, would the default choices come back to previous selected filters, or everything would be wiped off? The former would be preferred if possible

So I agree when turning the filter panel back on - the filters which were active at the time the filter panel was turned off should be turned back on again - as is the case here

@Polkas Polkas self-assigned this Nov 7, 2022
Polkas added a commit that referenced this issue Nov 16, 2022
closes #84 

Global toggle for Filter Panel, where the hidden state is recovered when
turn on.
The current UI design is following recommended by Pawel and Nina
direction.

Co-authored-by: NEST Core Team
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
5 participants