-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce disable filters in FilterPanelApi/FilteredData #84
Comments
Should this be module specific? Isn't it easier for both app developers and app users to have one global toggle which turns the filter panel on/off for all modules? i.e. here |
Hi @kumamiao, can you help us on this? Do you think user would prefer global on/off or module-level on/off? |
I feel like should we consider putting a hold on this issue, as we're planning for a bigger design change for the filter panel (which could potentially involve the setup for global & module-specific filters)? |
@kumamiao we prefer to go through as we are working on the feature branch (this won't land on main until we have a stable teal version). This will be easier for developers to move forward with having quosure implemented in all modules. Disable/enable filters can be reverted and modified at any point. |
In this case let's move forward with this issue. I would propose to go with what Nik suggested, have one global toggle which turns the filter panel on/off for all modules - although one concern here, if switched from on->off->on, would the default choices come back to previous selected filters, or everything would be wiped off? The former would be preferred if possible. In the future if we want to enable and then implement module-level toggle, then that toggle would be only applicable for module-specific filters and not impact global filters. |
So I agree when turning the filter panel back on - the filters which were active at the time the filter panel was turned off should be turned back on again - as is the case here |
closes #84 Global toggle for Filter Panel, where the hidden state is recovered when turn on. The current UI design is following recommended by Pawel and Nina direction. Co-authored-by: NEST Core Team
Please add option to disable filters for particular module. This particular module should get unfiltered data when toggle filter through FilterPanelApi
The text was updated successfully, but these errors were encountered: