-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update to qenv #462
update to qenv #462
Conversation
LGTM - approve |
@@ -77,7 +77,7 @@ tm_front_page <- function(label = "Front page", | |||
ui = ui_front_page, | |||
ui_args = args, | |||
server_args = list(tables = tables, show_metadata = show_metadata), | |||
filters = NULL | |||
filters = if (show_metadata) "all" else NULL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like this, but if I don't do this I get an error from teal saying if filters = NULL then you cannot use data
@pawelru this is starting to look really nice - it shouldn't be too hard to remove the do.call etc.
Note the reporter buttons don't do anything and after insightsengineering/teal#678 they won't appear at all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Part of insightsengineering/teal.code#34 see insightsengineering/teal.code#74
I also replaced dontrun with if (interactive()) as it was annoying me so much not being able to run the apps in RSrudio easily