change id in panel_item (#124)

While doing this insightsengineering/teal.modules.general#496, I realized that the `id` on the div should be one place higher. @Polkas confirmed the point. Signed-off-by: Maciej Nasinski <[email protected]> Co-authored-by: Maciej Nasinski <[email protected]>
insightsengineering · Dec 6, 2022 · 1d77191 · 1d77191
1 parent b1e62bc
commit 1d77191
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/NEWS.md b/NEWS.md
@@ -12,6 +12,7 @@
 ### Bug fixes
 
 * Added labels to pagination button in `table_with_settings` and fixed alt text.
+* Fixed the html structure of `panel_item` function.
 
 ### Miscellaneous
 

diff --git a/R/panel_group.R b/R/panel_group.R
@@ -65,9 +65,9 @@ panel_item <- function(title, ..., collapsed = TRUE, input_id = NULL) {
     if (bs_version == "3") {
       res_tag$children <- list(
         tags$div(
+          id = div_id,
           class = "panel panel-default",
           tags$div(
-            id = div_id,
             class = paste("panel-heading", ifelse(collapsed, "collapsed", "")),
             `data-toggle` = "collapse",
             href = paste0("#", panel_id),