Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change id in panel_item #124

Merged
merged 4 commits into from
Dec 6, 2022
Merged

change id in panel_item #124

merged 4 commits into from
Dec 6, 2022

Conversation

mhallal1
Copy link
Contributor

@mhallal1 mhallal1 commented Dec 6, 2022

While doing this insightsengineering/teal.modules.general#496, I realized that the id on the div should be one place higher.
@Polkas confirmed the point.

@mhallal1 mhallal1 added the core label Dec 6, 2022
@mhallal1 mhallal1 requested a review from Polkas December 6, 2022 10:05
@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2022

badge

Code Coverage Summary

Filename                   Stmts    Miss  Cover    Missing
-----------------------  -------  ------  -------  ----------------------------------------------------------
R/basic_table_args.R          23       0  100.00%
R/draggable_buckets.R         82      82  0.00%    44-139
R/get_dt_rows.R               13      13  0.00%    27-39
R/ggplot2_args.R              49       0  100.00%
R/include_css_js.R             7       1  85.71%   17
R/optionalInput.R            218     185  15.14%   78-353, 405, 440, 444, 448, 450, 456, 471-484
R/panel_group.R               89      89  0.00%    12-130
R/plot_with_settings.R       382      24  93.72%   271-284, 306, 343-344, 355-356, 365-366, 610-611, 613, 615
R/standard_layout.R           40       0  100.00%
R/table_with_settings.R      171      51  70.18%   85, 99-111, 184, 191-203, 209, 212-228, 230-235
R/utils.R                      4       1  75.00%   7
R/verbatim_popup.R            96      47  51.04%   67-86, 99, 122-150, 171
R/white_small_well.R           7       7  0.00%    18-24
TOTAL                       1181     500  57.66%

Diff against main

Filename    Stmts    Miss    Cover
----------  -------  ------  -------
TOTAL       -        -       -

Results for commit: 768a476

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2022

Unit Tests Summary

    1 files      9 suites   9s ⏱️
  88 tests   86 ✔️ 2 💤 0
175 runs  173 ✔️ 2 💤 0

Results for commit c58ef17.

♻️ This comment has been updated with latest results.

NEWS.md Outdated Show resolved Hide resolved
Signed-off-by: Maciej Nasinski <[email protected]>
Copy link
Contributor

@Polkas Polkas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhallal1 mhallal1 merged commit 1d77191 into main Dec 6, 2022
@mhallal1 mhallal1 deleted the move_id@main branch December 6, 2022 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants