Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invisible grob plot on popup #175

Closed
wants to merge 2 commits into from

Conversation

vedhav
Copy link
Contributor

@vedhav vedhav commented Aug 7, 2023

Closes #171

The grid::grid.draw() is already handled by the shiny::renderPlot so we just need to let shiny do its thing.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2023

Unit Tests Summary

    1 files    10 suites   22s ⏱️
  97 tests   96 ✔️ 0 💤 0  1 🔥
211 runs  210 ✔️ 0 💤 0  1 🔥

For more details on these errors, see this check.

Results for commit e81a588.

♻️ This comment has been updated with latest results.

@vedhav vedhav force-pushed the 171-fix-invisible-plot-on-popup@main branch from 1a5afce to e81a588 Compare August 7, 2023 07:46
@kartikeyakirar
Copy link
Contributor

@vedhav, I was also addressing the same issue. Kindly assign the task to yourself once you begin working on it 😉. this solution actually break the association plot.

@vedhav
Copy link
Contributor Author

vedhav commented Aug 7, 2023

Oh! Sorry about that. Do you want to take this branch then?

@kartikeyakirar
Copy link
Contributor

no worries , I have pushed changes to branch please have look. #176

@vedhav
Copy link
Contributor Author

vedhav commented Aug 7, 2023

Closing the PR in favor of the new PR #176

@vedhav vedhav closed this Aug 7, 2023
@vedhav vedhav deleted the 171-fix-invisible-plot-on-popup@main branch August 7, 2023 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: plot_with_settings does not show plot in exploratory app
2 participants