Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing rendering of grob obj on modal popup #547 #176

Merged
merged 30 commits into from
Aug 8, 2023

Conversation

kartikeyakirar
Copy link
Contributor

@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2023

badge

Code Coverage Summary

Filename                   Stmts    Miss  Cover    Missing
-----------------------  -------  ------  -------  ---------------------------------------------
R/basic_table_args.R          23       0  100.00%
R/draggable_buckets.R         82      82  0.00%    57-152
R/get_dt_rows.R               13      13  0.00%    27-39
R/ggplot2_args.R              49       0  100.00%
R/include_css_js.R             7       1  85.71%   17
R/optionalInput.R            218     185  15.14%   87-362, 414, 449, 453, 457, 459, 465, 480-493
R/panel_group.R               89      89  0.00%    12-130
R/plot_with_settings.R       382      21  94.50%   272-285, 344-345, 356-357, 607-608, 610, 612
R/standard_layout.R           40       0  100.00%
R/table_with_settings.R      173       1  99.42%   79
R/utils.R                     11       1  90.91%   7
R/verbatim_popup.R           100      49  51.00%   64-79, 105-106, 108, 116-144, 165
R/white_small_well.R           7       7  0.00%    18-24
TOTAL                       1194     449  62.40%

Diff against main

Filename                  Stmts    Miss  Cover
----------------------  -------  ------  -------
R/plot_with_settings.R       -1       0  -0.01%
R/utils.R                    +7       0  +15.91%
TOTAL                        +6       0  +0.19%

Results for commit: 50c2a9b

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2023

Unit Tests Summary

    1 files    10 suites   23s ⏱️
101 tests 101 ✔️ 0 💤 0
208 runs  208 ✔️ 0 💤 0

Results for commit 84a896e.

♻️ This comment has been updated with latest results.

Comment on lines -368 to -372
} else if (plot_type() == "grob") {
# calling grid.draw on plot_r() is needed;
# otherwise the plot will not re-render if the user triggers the zoom in or out feature of the browser.
grid::grid.newpage()
grid::grid.draw(plot_r())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why it didn't worked here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When the 'grob' is re-rendered for a modal pop-up, it's not displaying the image as expected. Initially, I suspected that the changes I made in teal.code for the 'qenv' might be the cause, particularly due to the use of 'pdf(null.file())'. However, upon further investigation, it appears that this is not the root of the problem.

I still not sure whats the issue but when plot_reactive() is called second time it does not render it for grob object

inst/WORDLIST Outdated Show resolved Hide resolved
R/utils.R Outdated Show resolved Hide resolved
tests/testthat/test-utils.R Outdated Show resolved Hide resolved
R/plot_with_settings.R Outdated Show resolved Hide resolved
R/plot_with_settings.R Outdated Show resolved Hide resolved
Copy link
Contributor

@gogonzo gogonzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BUG fixed, please address all comments before a merge

@gogonzo gogonzo self-assigned this Aug 8, 2023
@kartikeyakirar kartikeyakirar merged commit 3247a7e into main Aug 8, 2023
23 checks passed
@kartikeyakirar kartikeyakirar deleted the 547_grob_rendering@main branch August 8, 2023 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants