-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixing rendering of grob obj on modal popup #547 #176
Conversation
Code Coverage Summary
Diff against main
Results for commit: 50c2a9b Minimum allowed coverage is ♻️ This comment has been updated with latest results |
} else if (plot_type() == "grob") { | ||
# calling grid.draw on plot_r() is needed; | ||
# otherwise the plot will not re-render if the user triggers the zoom in or out feature of the browser. | ||
grid::grid.newpage() | ||
grid::grid.draw(plot_r()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why it didn't worked here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When the 'grob'
is re-rendered for a modal pop-up, it's not displaying the image as expected. Initially, I suspected that the changes I made in teal.code for the 'qenv'
might be the cause, particularly due to the use of 'pdf(null.file())'. However, upon further investigation, it appears that this is not the root of the problem.
I still not sure whats the issue but when plot_reactive()
is called second time it does not render it for grob object
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BUG fixed, please address all comments before a merge
Co-authored-by: Dawid Kałędkowski <[email protected]> Signed-off-by: kartikeya kirar <[email protected]>
Co-authored-by: Dawid Kałędkowski <[email protected]> Signed-off-by: kartikeya kirar <[email protected]>
Co-authored-by: Dawid Kałędkowski <[email protected]> Signed-off-by: kartikeya kirar <[email protected]>
fixes insightsengineering/teal.modules.general#547