Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle reactivity for disabled in modules #98

Closed
wants to merge 7 commits into from

Conversation

nikolas-burkoff
Copy link
Contributor

@nikolas-burkoff nikolas-burkoff commented Oct 26, 2022

@nikolas-burkoff nikolas-burkoff changed the title 63 warnings@teal refactor@main Handle reactivity for disabled in modules Oct 26, 2022
@github-actions
Copy link
Contributor

badge

Code Coverage Summary

Filename                   Stmts    Miss  Cover    Missing
-----------------------  -------  ------  -------  ------------------------------
R/basic_table_args.R          23       0  100.00%
R/draggable_buckets.R         82      82  0.00%    44-139
R/get_dt_rows.R               13      13  0.00%    27-39
R/ggplot2_args.R              49       0  100.00%
R/include_css_js.R             7       7  0.00%    12-19
R/optionalInput.R            218     196  10.09%   78-353, 405, 438-484
R/panel_group.R               89      89  0.00%    12-130
R/plot_with_settings.R       378     372  1.59%    8-583
R/standard_layout.R           40       0  100.00%
R/table_with_settings.R      167     167  0.00%    11-236
R/utils.R                      4       1  75.00%   7
R/verbatim_popup.R            95      53  44.21%   52-74, 90-91, 93, 116-144, 165
R/white_small_well.R           7       7  0.00%    18-24
TOTAL                       1172     987  15.78%

Diff against main

Filename              Stmts    Miss  Cover
------------------  -------  ------  -------
R/verbatim_popup.R       +5      +4  -1.35%
TOTAL                    +5      +4  +0.02%

Results for commit: d44d0f7

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions
Copy link
Contributor

Unit Tests Summary

    1 files      7 suites   1s ⏱️
  63 tests   62 ✔️ 0 💤 0  1 🔥
109 runs  108 ✔️ 0 💤 0  1 🔥

For more details on these errors, see this check.

Results for commit 04dca6d.

@nikolas-burkoff
Copy link
Contributor Author

Closed in favour of #99

@nikolas-burkoff nikolas-burkoff deleted the 63_warnings@teal_refactor@main branch October 27, 2022 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant