Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disabled in verbatim_popup_srv is longer triggered when button i… #99

Merged
merged 5 commits into from
Oct 27, 2022
Merged

disabled in verbatim_popup_srv is longer triggered when button i… #99

merged 5 commits into from
Oct 27, 2022

Conversation

gogonzo
Copy link
Contributor

@gogonzo gogonzo commented Oct 27, 2022

@github-actions
Copy link
Contributor

github-actions bot commented Oct 27, 2022 •
edited
Loading

badge

Code Coverage Summary

Filename                   Stmts    Miss  Cover    Missing
-----------------------  -------  ------  -------  -----------------------
R/basic_table_args.R          23       0  100.00%
R/draggable_buckets.R         82      82  0.00%    44-139
R/get_dt_rows.R               13      13  0.00%    27-39
R/ggplot2_args.R              49       0  100.00%
R/include_css_js.R             7       7  0.00%    12-19
R/optionalInput.R            218     196  10.09%   78-353, 405, 438-484
R/panel_group.R               89      89  0.00%    12-130
R/plot_with_settings.R       378     372  1.59%    8-583
R/standard_layout.R           40       0  100.00%
R/table_with_settings.R      167     167  0.00%    11-236
R/utils.R                      4       1  75.00%   7
R/verbatim_popup.R            91      47  48.35%   57-76, 89, 112-140, 161
R/white_small_well.R           7       7  0.00%    18-24
TOTAL                       1168     981  16.01%

Diff against main

Filename              Stmts    Miss  Cover
------------------  -------  ------  -------
R/verbatim_popup.R       +1      -2  +2.80%
TOTAL                    +1      -2  +0.24%

Results for commit: c4da084

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@nikolas-burkoff nikolas-burkoff mentioned this pull request Oct 27, 2022
Closed
@nikolas-burkoff nikolas-burkoff self-assigned this Oct 27, 2022
@github-actions
Copy link
Contributor

Unit Tests Summary

    1 files      7 suites   1s ⏱️
  63 tests   63 ✔️ 0 💤 0 ❌
109 runs  109 ✔️ 0 💤 0 ❌

Results for commit a365afc.

nikolas-burkoff
nikolas-burkoff approved these changes Oct 27, 2022
View reviewed changes
Copy link
Contributor

@nikolas-burkoff nikolas-burkoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@gogonzo gogonzo merged commit c138a70 into main Oct 27, 2022
@gogonzo gogonzo deleted the trigget_when_displayed@main branch October 27, 2022 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikolas-burkoff nikolas-burkoff nikolas-burkoff approved these changes

Assignees

@nikolas-burkoff nikolas-burkoff

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gogonzo @nikolas-burkoff