Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds min package version #912

Merged
merged 8 commits into from
Nov 22, 2023
Merged

Adds min package version #912

merged 8 commits into from
Nov 22, 2023

Conversation

averissimo
Copy link
Contributor

@averissimo averissimo commented Sep 1, 2023

WIP :: parent issue: insightsengineering/nestdevs-tasks#7

🔴 Checklist for PR Reviewer

Scheduled 🕰️ (max and release strategies are expected to fail... see below)

  • Tag yourself next to this repo on Specify minimal version dependencies + add action nestdevs-tasks#7
  • Package versions are the same or higher than main
  • Package list is the same
    • Only exception is rmarkdown (may have been removed on Suggests)
  • All packages in Imports, Depends & Suggests are in new section Config/Needs/verdepcheck
  • Added entry to NEWS.md
  • Last scheduled.yaml action was run succesfully (all 4 strategies)
    • important: it's not the last commit, it's the one that runs 4 Scheduled 🕰️ / Dependency actions
  • scheduled.yaml SHOULD NOT have any push on any branches

🔴 What's needed before merging?

This PR depends on some upstream changes that need to be finalized/merged before being ready to review.

Change in code

  • verdepcheck.yml action (see comments)
    • Remove on: push section
    • Change branch to main

PRS

Changes description

  • Adds minimum version for packages DESCRIPTION
  • Adds Config/Need/verdepcheck section in DESCRIPTION
  • Updates verdepcheck action

@averissimo averissimo force-pushed the verdepcheck_action branch 2 times, most recently from 957a298 to ce7b7e6 Compare September 21, 2023 09:28
@averissimo averissimo marked this pull request as ready for review September 26, 2023 12:31
@github-actions
Copy link
Contributor

github-actions bot commented Sep 26, 2023

badge

Code Coverage Summary

Filename                         Stmts    Miss  Cover    Missing
-----------------------------  -------  ------  -------  -------------------------------------------------------------------------------------------------------------------------------
R/dummy_functions.R                 92      50  45.65%   9-71
R/get_rcode_utils.R                 38       1  97.37%   50
R/include_css_js.R                  24       0  100.00%
R/init.R                            79      25  68.35%   139, 164-185, 217-219, 221-223, 225-226
R/landing_popup_module.R            25      25  0.00%    61-87
R/module_filter_manager.R          107      29  72.90%   62-70, 79-84, 228, 233-246
R/module_nested_tabs.R             174      14  91.95%   72, 119, 138-145, 163, 216, 238, 271
R/module_snapshot_manager.R        209     157  24.88%   87-99, 127-136, 140-152, 154-161, 168-182, 186-188, 190-195, 198-208, 211-227, 236-251, 265-288, 291-302, 305-311, 325, 346-369
R/module_tabs_with_filters.R        73       2  97.26%   95, 140
R/module_teal_with_splash.R        120      11  90.83%   73, 87-95, 122
R/module_teal.R                    141       8  94.33%   68, 71, 158-159, 165, 196, 204-205
R/modules_debugging.R               18      18  0.00%    25-44
R/modules.R                        143      26  81.82%   119, 132, 226-229, 243-248, 259-263, 378-421
R/reporter_previewer_module.R       18       2  88.89%   26, 30
R/show_rcode_modal.R                20      20  0.00%    16-37
R/tdata.R                           39       1  97.44%   158
R/teal_data_module.R                 6       0  100.00%
R/teal_reporter.R                   60       5  91.67%   65, 116-117, 120, 137
R/teal_slices-store.R               25       0  100.00%
R/teal_slices.R                     59      12  79.66%   135-148
R/utils.R                          108      27  75.00%   113-140
R/validate_inputs.R                 32       0  100.00%
R/validations.R                     58      37  36.21%   109-371
R/zzz.R                             11       7  36.36%   3-14
TOTAL                             1679     477  71.59%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: b069692

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions
Copy link
Contributor

github-actions bot commented Sep 26, 2023

Unit Tests Summary

    1 files    18 suites   12s ⏱️
195 tests 195 ✔️ 0 💤 0
367 runs  367 ✔️ 0 💤 0

Results for commit b069692.

♻️ This comment has been updated with latest results.

@averissimo
Copy link
Contributor Author

averissimo commented Sep 26, 2023

The action is failing for the following strategies:

  • max: Due to errors with development versions of dependencies
  • release: Due to teal.slice-v0.1.3.9011 not being a "released" version of the package
    • Neither on CRAN or in GitHub tag

This will resolve itself once new version of teal.slice is released

@averissimo averissimo merged commit 669c172 into main Nov 22, 2023
24 checks passed
@averissimo averissimo deleted the verdepcheck_action branch November 22, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants