Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge replace_emptys_with_na and df_explicit_na into the second #720

Closed
Melkiades opened this issue Oct 5, 2022 · 0 comments · Fixed by #768
Closed

Merge replace_emptys_with_na and df_explicit_na into the second #720

Melkiades opened this issue Oct 5, 2022 · 0 comments · Fixed by #768
Assignees
@edelarua
Labels
low-priority refactor sme

Comments

@Melkiades
Copy link
Contributor

Speaking of reinventing the wheel, I wrote replace_emptys_with_na to do what df_explicit_na. Merging the two functions involves checking both logic and merging their functionalities by selecting and integrating logic and functionalities.
@Melkiades Melkiades self-assigned this Nov 3, 2022
@Melkiades Melkiades removed their assignment Nov 14, 2022
@edelarua edelarua self-assigned this Dec 9, 2022
@edelarua edelarua mentioned this issue Dec 9, 2022
Merged
edelarua added a commit that referenced this issue Dec 9, 2022
@edelarua @github-actions
720 Remove replace_emptys_with_na (#768)
09d1a6b 
Closes #720

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@edelarua edelarua

Labels
low-priority refactor sme
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

720 Remove replace_emptys_with_na insightsengineering/tern
2 participants
@Melkiades @edelarua