Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

720 Remove replace_emptys_with_na #768

Merged
merged 6 commits into from
Dec 9, 2022
Merged

720 Remove replace_emptys_with_na #768

merged 6 commits into from
Dec 9, 2022

Conversation

edelarua
Copy link
Contributor

@edelarua edelarua commented Dec 9, 2022

Closes #720

@edelarua edelarua added the sme label Dec 9, 2022
@Melkiades Melkiades self-requested a review December 9, 2022 15:10
Melkiades
Melkiades approved these changes Dec 9, 2022
View reviewed changes
Copy link
Contributor

@Melkiades Melkiades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally someone taking care of this!! thanks Emily. I also took a moment to check if df_explicit_na had complete coverage and it looks perfect! I am still reluctant to see my first function added to NEST go out of tern, but it has to be done ahah

@edelarua edelarua enabled auto-merge (squash) December 9, 2022 16:09
@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2022

Unit Tests Summary

       1 files     126 suites   2m 52s ⏱️
   871 tests    871 ✔️ 0 💤 0 ❌
1 314 runs  1 314 ✔️ 0 💤 0 ❌

Results for commit 32a767f.

@edelarua edelarua merged commit 09d1a6b into main Dec 9, 2022
@edelarua edelarua deleted the 720_remove_replace_emptys_with_na@main branch December 9, 2022 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Melkiades Melkiades Melkiades approved these changes

Assignees
No one assigned
Labels
enhancement sme
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Merge replace_emptys_with_na and df_explicit_na into the second
2 participants
@edelarua @Melkiades