change cohort_id and strata to subject_var and group_var.
#1106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
what do you think @clarkliming ? |
|
Code Coverage SummaryDiff against mainResults for commit: 16271a3 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
We will probably shield it so it doesn't really matter for now but maybe on the long(er) run |
|
i am inclined to block this pr, and merge it in the next PI, potential breaking change @Melkiades @ayogasekaram @edelarua @BFalquet @clarkliming , let me know what you think |
We are wrapping it so no problem on our side, we can postpone. |
Signed-off-by: Davide Garolini <[email protected]>
|
@ayogasekaram can you open PRs in scda.test and TLG-c to accommodate these changes? |
2 tasks
|
@Melkiades I've put up a PR in tlg-c which can be merged after the description file is updated. scda.test does not cover graphs currently so there is nothing to update there. I will create a separate issue to include plots in scda.test and add this to the task list. |
Signed-off-by: Davide Garolini <[email protected]>
Signed-off-by: Davide Garolini <[email protected]>
Melkiades
reviewed
Oct 31, 2023
| @@ -5,12 +5,14 @@ | |||
| #' Line plot with the optional table. | |||
| #' | |||
| #' @param df (`data.frame`)\cr data set containing all analysis variables. | |||
| #' @param alt_counts_df (`data.frame` or `NULL`)\cr data set that will be used (only) to counts objects in strata. | |||
| #' @param alt_counts_df (`data.frame` or `NULL`)\cr data set that will be used (only) | |||
| #' to counts objects in groups for stratification. | |||
There was a problem hiding this comment.
Can you still add (or strata) after group where you specified it? so we get a bit of continuity and its searchable
Melkiades
reviewed
Oct 31, 2023
| #' @param variables (named `character` vector) of variable names in `df` data set. Details are: | ||
| #' * `x` (`character`)\cr name of x-axis variable. | ||
| #' * `y` (`character`)\cr name of y-axis variable. | ||
| #' * `strata` (`character`)\cr name of grouping variable, i.e. treatment arm. Can be `NA` to indicate lack of groups. |
There was a problem hiding this comment.
we need to deprecate it I think (the same goes for the other param changes). Follow what Emily did with na_level :)
…/tern into 1105_fix_params@main
ayogasekaram
added a commit
to insightsengineering/tlg-catalog
that referenced
this pull request
Nov 1, 2023
closes #136 merge after: - [x] merging [this PR](insightsengineering/tern#1106) in tern - [x] Update tern package version in DESCRIPTION
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1105
should the
strata_Nobject in the function be renamed togroup_N?