Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update g_lineplot variable names. #137

Merged
merged 3 commits into from
Nov 1, 2023
Merged

update g_lineplot variable names. #137

merged 3 commits into from
Nov 1, 2023

Conversation

ayogasekaram
Copy link
Contributor

@ayogasekaram ayogasekaram commented Oct 27, 2023 •
edited by Melkiades
Loading

closes #136

merge after:

  • merging this PR in tern
  • Update tern package version in DESCRIPTION

Melkiades
Melkiades approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@Melkiades Melkiades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Thanks Abi :)

Add also scda.test if you can ;)

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 1, 2023

Unit Tests Summary

    1 files  2 suites   57s ⏱️
  26 tests 0 ✔️   26 💤 0 ❌
281 runs  0 ✔️ 281 💤 0 ❌

Results for commit 25dc7d9.

@ayogasekaram ayogasekaram merged commit af743b9 into main Nov 1, 2023
14 checks passed
@ayogasekaram ayogasekaram deleted the 136_update_var_names@main branch November 1, 2023 15:08
@edelarua
Copy link
Contributor

Reverted in #152 to fix catalog rendering - reapply these changes after next tern release (v0.9.3).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Melkiades Melkiades Melkiades approved these changes

Assignees
No one assigned
Labels
sme
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update variable names
3 participants
@ayogasekaram @edelarua @Melkiades