Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update RMPT templates to use analyze function #45

Merged
merged 1 commit into from
May 17, 2023
Merged

Update RMPT templates to use analyze function #45

merged 1 commit into from
May 17, 2023

Conversation

edelarua
Copy link
Contributor

@edelarua edelarua commented May 12, 2023 •
edited
Loading

Closes #44

@shajoezhu shajoezhu marked this pull request as ready for review May 15, 2023 08:57
@shajoezhu shajoezhu removed the blocked label May 15, 2023
@sob2021 sob2021 self-requested a review May 16, 2023 14:58
sob2021
sob2021 approved these changes May 17, 2023
View reviewed changes
Copy link

@sob2021 sob2021 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @edelarua
All looks good.

@edelarua edelarua merged commit 397a6ea into main May 17, 2023
@edelarua edelarua deleted the 44_refactor_rmpt@main branch May 17, 2023 15:55
@edelarua edelarua mentioned this pull request May 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sob2021 sob2021 sob2021 approved these changes

Assignees
No one assigned
Labels
sme
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reimplement RMPT01 with analyze function
3 participants
@edelarua @sob2021 @shajoezhu