Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update rmpt01_test #46

Merged
merged 5 commits into from
May 17, 2023
Merged

update rmpt01_test #46

merged 5 commits into from
May 17, 2023

Conversation

sob2021
Copy link
Contributor

@sob2021 sob2021 commented May 17, 2023

closes #45

@github-actions
Copy link
Contributor

github-actions bot commented May 17, 2023 •
edited
Loading

Unit Tests Summary

    1 files  111 suites   3m 0s ⏱️
245 tests 234 ✔️   11 💤 0 ❌
490 runs  245 ✔️ 245 💤 0 ❌

Results for commit b01c1ce.

♻️ This comment has been updated with latest results.

@sob2021
Copy link
Contributor Author

sob2021 commented May 17, 2023

R CMD check failure. Issue is being fixed, see here

@edelarua
Copy link
Contributor

@sob2021 can you also update RMPT03, RMPT04, and RMPT05 in this PR? It will probably be the same changes for each template.

Typically when we update tlg-catalog we then want to make the same changes in scda.test to make sure we're testing the identical templates - the associated PR in tlg-catalog for this one is insightsengineering/tlg-catalog#45.

Thanks! :)

@sob2021
Copy link
Contributor Author

sob2021 commented May 17, 2023

Thank you @edelarua, updates made.

edelarua
edelarua approved these changes May 17, 2023
View reviewed changes
Copy link
Contributor

@edelarua edelarua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Thanks @sob2021

@edelarua
Copy link
Contributor

You will have to wait to merge until #44 is merged since tests are failing.

@shajoezhu shajoezhu merged commit 23ae4f2 into main May 17, 2023
@shajoezhu shajoezhu deleted the 45_update_rmpt01_test branch May 17, 2023 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edelarua edelarua edelarua approved these changes

Assignees
No one assigned
Labels
blocked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

update rmpt01 test
3 participants
@sob2021 @edelarua @shajoezhu