feat: JSON Files Merging Script #44
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RuanJohn
requested changes
Jan 22, 2024
There was a problem hiding this comment.
Thank you for this @OmaymaMahjoub ! Just some minor comments :)
Co-authored-by: RuanJohn <[email protected]>
RuanJohn
reviewed
Jan 30, 2024
RuanJohn
reviewed
Jan 30, 2024
RuanJohn
reviewed
Jan 30, 2024
|
Closing because the same code is in #45 and it is easier to review only one PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Add a function that helps in merging multiple json files that contains different algos or envs or tasks or seeds related to the same experiment setup in order to have a centralised json file that will be used in the plotting tools.
Why?
We often run experiments on different computes causing us to have the same benchmark experiments in different json files.