Feat: pull from neptune tools #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RuanJohn
requested changes
Jan 22, 2024
There was a problem hiding this comment.
Thank you @OmaymaMahjoub, some minor comments. A lot of these actually depends on how data is stored on Mava's side. I will make a PR there as soon as possible and then we can look at exactly how we want to pull files down and unzip them.
RuanJohn
reviewed
Jan 30, 2024
RuanJohn
reviewed
Jan 30, 2024
RuanJohn
reviewed
Jan 30, 2024
Co-authored-by: RuanJohn <[email protected]>
RuanJohn
reviewed
Jan 30, 2024
RuanJohn
reviewed
Jan 30, 2024
RuanJohn
reviewed
Jan 30, 2024
RuanJohn
reviewed
Jan 30, 2024
RuanJohn
reviewed
Jan 30, 2024
RuanJohn
reviewed
Jan 30, 2024
RuanJohn
reviewed
Jan 30, 2024
RuanJohn
reviewed
Jan 30, 2024
RuanJohn
reviewed
Jan 30, 2024
RuanJohn
reviewed
Jan 30, 2024
RuanJohn
reviewed
Jan 30, 2024
RuanJohn
requested changes
Jan 30, 2024
There was a problem hiding this comment.
Thank you @OmaymaMahjoub! This looks good and is super useful. Mainly just some minor README and naming suggestions from my side.
Co-authored-by: RuanJohn <[email protected]>
Co-authored-by: RuanJohn <[email protected]>
Co-authored-by: RuanJohn <[email protected]>
Co-authored-by: RuanJohn <[email protected]>
Co-authored-by: RuanJohn <[email protected]>
Co-authored-by: RuanJohn <[email protected]>
Co-authored-by: RuanJohn <[email protected]>
RuanJohn
reviewed
Feb 1, 2024
RuanJohn
reviewed
Feb 1, 2024
Co-authored-by: RuanJohn <[email protected]>
Co-authored-by: RuanJohn <[email protected]>
RuanJohn
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Add
pull_neptune_datafunction to pull the experiments data from Neptune to a local directory.Why?
This function is particularly useful when there is a need to pull data from multiple experiments.
How?
Extra
This PR is based on #44!